Repository navigation
Extend the shared Renovate preset; stop Renovate bumping Sourcegraph images - #1442
Open
marcleblanc2 wants to merge 1 commit into
Open
marcleblanc2 wants to merge 1 commit into
marcleblanc2 wants to merge 1 commit into
Conversation
…images Sourcegraph image tags in docker-compose/ are pinned by the release process (release.yaml), so Renovate's image-bump PRs only ever got closed as stale. Disable them, extend sourcegraph/renovate-config like the other repos, batch non-major updates into one weekly PR, and re-enable direct Go module updates (the shared preset disables Go). Amp-Thread-ID: https://ampcode.com/threads/T-01a13d0e-f8a7-7760-b810-54d32d07cf6a Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate's Sourcegraph image PRs here only ever get closed as stale (#1185, #1186, and now #1439, #1440): the image tags in
docker-compose/are pinned by the release process (sg ops update-imagesinrelease.yaml), not Renovate. The rest of the config was from 2020 and used options Renovate has since renamed (#1437).Changes
sourcegraph/renovate-configpreset, like the other sourcegraph reposindex.docker.io/sourcegraph/*images; Renovate will auto-close Update Sourcegraph Docker images to v8 #1439 and Update Sourcegraph Prometheus / Grafana Docker images to v8 #1440// indirectdeps and thegodirective stay off, as Renovate recommendsgroup:allNonMajor+schedule:weekly); majors still get their own PRenterprise/dev/ci/imagesrule and the per-ruleautomergeSupersedes #1437. Conflicts trivially with #1433 on
renovate.json; whichever lands second gets a rebase.Checklist
Test plan
renovate-config-validator --strict renovate.json(Renovate 44.151.1) passesyarn run prettier-checkpassesrenovate --dry-run=lookup(Renovate 44,github>preset) against this branch: all 24index.docker.io/sourcegraph/*images reportskipReason: disabled; 16// indirectGo deps and thegodirective reportdisabled; direct Go requires (golang.org/x/mod,github.com/urfave/cli/v2),@sourcegraph/prettierrc, and.tool-versionsland inrenovate/all-minor-patch; majors (prettier3, Node 24,urfave/cliv3) get separate branches