Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Development/bst/filesystem.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@

#elif defined(_MSC_VER)

#if _MSC_VER >= 1910
#if _MSC_VER >= 1951

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be 1950 instead of 1951?
See MSCV Build Tools version table in https://learn.microsoft.com/en-us/cpp/overview/compiler-versions?view=msvc-180

Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not according to the release notes that I linked.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right.

// From VS2026, or more precisely, MSVC Build Tools v14.51, <experimental/filesystem> is finally removed
// See https://learn.microsoft.com/en-us/visualstudio/releases/2026/release-notes
// and https://github.com/microsoft/STL/pull/5765
#define BST_FILESYSTEM_STD
#elif _MSC_VER >= 1910
// From VS2017, /std:c++17 switch is introduced, but this is only indicated in __cplusplus if /Zc:__cplusplus is also specified
#if __cplusplus >= 201703L
#define BST_FILESYSTEM_STD
Expand Down
Loading