Add invite-only registration mode - #1223
Open
korridor wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1223 +/- ##
============================================
+ Coverage 89.36% 89.38% +0.02%
- Complexity 2090 2100 +10
============================================
Files 283 284 +1
Lines 10117 10137 +20
============================================
+ Hits 9041 9061 +20
Misses 1076 1076 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Support configurable on, invite-only, and off registration modes, including case-insensitive invitation checks and test coverage.
korridor
force-pushed
the
feature/registration_excl_invites
branch
from
August 25, 2026 16:20
789ec15 to
303de49
Compare
Onatcer
reviewed
Aug 25, 2026
|
|
||
| public function test_invited_user_can_register_if_registration_is_invite_only(): void | ||
| { | ||
| Config::set('app.enable_registration', 'invite'); |
Contributor
There was a problem hiding this comment.
imo this should always test the same config not "invite" in one test and then "invite-only" in the other one
| APP_DEBUG=true | ||
| APP_URL=https://solidtime.test | ||
| APP_FORCE_HTTPS=false | ||
| # Supported values: on/true, invite/invite-only, off/false |
Contributor
There was a problem hiding this comment.
i'm fine with accepting both values as a fallback but i dont really see a reason for documenting 2 ways to do the same thing. i also think we should replace the ture/false examples and docs and have it consistently on/invite/off or on/invite-only/off everywhere.
| 'force_https' => (bool) env('APP_FORCE_HTTPS', false), | ||
|
|
||
| 'enable_registration' => (bool) env('APP_ENABLE_REGISTRATION', false), | ||
| 'enable_registration' => env('APP_ENABLE_REGISTRATION', false), |
Contributor
There was a problem hiding this comment.
i think this should be 'off' by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support configurable on, invite-only, and off registration modes, including case-insensitive invitation checks and test coverage.
What does this PR do?
Checklist (DO NOT REMOVE)