Add batch instruction helpers to JS client#147
Merged
lorisleiva merged 4 commits intomainfrom Apr 1, 2026
Merged
Conversation
febo
reviewed
Mar 31, 2026
Contributor
febo
left a comment
febo
left a comment
There was a problem hiding this comment.
Looks really good! I only have a few questions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR overrides the generated
getBatchInstructionandparseBatchInstructionhelpers such that you can work with its inner instructions directly.Note that it also updates the token binary on the
restart-test-validatorscript so that it uses the p-token binary. This is so that we can run JS tests for the newbatchinstruction that does not exist on the original token binary.