Skip to content

program: Expose check_manager_fee_info as pub for cross-program use#622

Merged
joncinque merged 1 commit intosolana-program:mainfrom
aoikurokawa:ak/check_manager_fee_info
Mar 25, 2026
Merged

program: Expose check_manager_fee_info as pub for cross-program use#622
joncinque merged 1 commit intosolana-program:mainfrom
aoikurokawa:ak/check_manager_fee_info

Conversation

@aoikurokawa
Copy link
Copy Markdown
Contributor

  • Changes the visibility of check_manager_fee_info from pub(crate) to pub to allow external programs to reuse this validation helper.

@joncinque
Copy link
Copy Markdown
Contributor

Thanks for your contribution -- I'm not against this PR, but is there a particular motivation for this change?

@aoikurokawa
Copy link
Copy Markdown
Contributor Author

Thanks for taking a look @joncinque !
The motivation is that we'd like to use this check in our own program. Currently, since it's private, we'd have to duplicate the logic on our side. Making it public would allow us to import and reuse it directly, which helps keep things consistent and avoids maintaining a separate copy.

Copy link
Copy Markdown
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, sounds good!

@joncinque joncinque changed the title Expose check_manager_fee_info as pub for cross-program use program: Expose check_manager_fee_info as pub for cross-program use Mar 25, 2026
@joncinque joncinque merged commit b3591ed into solana-program:main Mar 25, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants