fix(rewards-program): make CloseDirectRecipient permissionless when fully claimed#35
Open
fix(rewards-program): make CloseDirectRecipient permissionless when fully claimed#35
Conversation
…ully claimed Remove the recipient signer requirement from CloseDirectRecipient. The processor already gates closing on fully-claimed status, so the signer check was redundant. Previously only the recipient could close, but rent goes to original_payer — nobody was incentivized to call it. Now anyone can trigger the close once the recipient has fully claimed.
…ipient The recipient account is no longer a signer in the IDL, so the generated client expects Address instead of TransactionSigner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CloseDirectRecipientclaimed_amount >= total_amount, so the signer was redundantoriginal_payer— nobody was incentivized to call itrecipientaccount no longer marked assignerAudit finding: #4
Test plan
just buildcargo test -p rewards-program --libcargo test -p tests-rewards-program test_close_direct_recipient --lib