MPT-19967 refactor fixtures and remove redundant skip markers#298
Merged
MPT-19967 refactor fixtures and remove redundant skip markers#298
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (5)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis change moves helpdesk parameter fixtures into the parent helpdesk conftest, updates parameter-group-parameter fixtures to consume the relocated created-parameter fixtures, and removes module-level skip markers so parameter-related e2e tests run under the flaky marker. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/e2e/helpdesk/conftest.py`:
- Line 149: The payload contains a mismatched key "DisplayOrder" which should be
"displayOrder" to match the rest of the fixtures; locate the dict/fixture in
conftest.py where "DisplayOrder": None is set and rename the key to
"displayOrder": None, and scan the file for other occurrences of "DisplayOrder"
to replace so all payloads use the same camelCase key.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 5fe8e44f-fa1e-4dab-ba97-16748cf49dec
📒 Files selected for processing (9)
tests/e2e/helpdesk/conftest.pytests/e2e/helpdesk/parameter_groups/parameters/conftest.pytests/e2e/helpdesk/parameter_groups/parameters/test_async_parameters.pytests/e2e/helpdesk/parameter_groups/parameters/test_sync_parameters.pytests/e2e/helpdesk/parameter_groups/test_async_parameter_groups.pytests/e2e/helpdesk/parameter_groups/test_sync_parameter_groups.pytests/e2e/helpdesk/parameters/conftest.pytests/e2e/helpdesk/parameters/test_async_parameters.pytests/e2e/helpdesk/parameters/test_sync_parameters.py
💤 Files with no reviewable changes (1)
- tests/e2e/helpdesk/parameters/conftest.py
|
albertsola
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes MPT-19967
tests/e2e/helpdesk/conftest.py)parameter_data(short_uuid),invalid_parameter_id()(session),created_parameter(...), andasync_created_parameter(...)created_parameter/async_created_parameterand simplified creation payloadstests/e2e/helpdesk/parameters/conftest.pypytest.mark.skipfrom six e2e test modules so they now run underpytest.mark.flaky: