Skip to content

MPT-19487 update skip reasons in chat message tests#291

Merged
jentyk merged 1 commit intomainfrom
feat/MPT-19487
Apr 7, 2026
Merged

MPT-19487 update skip reasons in chat message tests#291
jentyk merged 1 commit intomainfrom
feat/MPT-19487

Conversation

@jentyk
Copy link
Copy Markdown
Member

@jentyk jentyk commented Apr 7, 2026

Closes MPT-19487

  • Updated skip reasons for test_update_chat_message_not_found and test_delete_chat_message_not_found test cases in both async and sync message test files, changing references from MPT-19124 to MPT-19964

@jentyk jentyk requested a review from a team as a code owner April 7, 2026 14:50
@jentyk jentyk requested review from alephsur and d3rky April 7, 2026 14:50
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 1e49f1d4-a9bb-4b2f-b067-d9f4e10f4ba2

📥 Commits

Reviewing files that changed from the base of the PR and between 2c52628 and 859aeaf.

📒 Files selected for processing (2)
  • tests/e2e/helpdesk/chats/messages/test_async_messages.py
  • tests/e2e/helpdesk/chats/messages/test_sync_messages.py

📝 Walkthrough

Walkthrough

Two e2e test files have skip decorator reason strings updated for two test cases each, changing the referenced issue from MPT-19124 to MPT-19964. No test logic, assertions, or behavior modifications were made.

Changes

Cohort / File(s) Summary
Test Skip Reason Updates
tests/e2e/helpdesk/chats/messages/test_async_messages.py, tests/e2e/helpdesk/chats/messages/test_sync_messages.py
Updated @pytest.mark.skip decorator reason strings for test_update_chat_message_not_found and test_delete_chat_message_not_found from "Unskip after MPT-19124 completed" to "Unskip after MPT-19964 completed".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key in the format MPT-19487, properly placed at the beginning.
Test Coverage Required ✅ Passed PR only modifies test files in tests/ folder; no code files outside tests/ folder are modified.
Single Commit Required ✅ Passed The pull request contains exactly one commit (859aeaf), which satisfies the requirement for a single commit and keeps git history clean.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 7, 2026

@jentyk jentyk merged commit 2377b40 into main Apr 7, 2026
4 checks passed
@jentyk jentyk deleted the feat/MPT-19487 branch April 7, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants