-
Notifications
You must be signed in to change notification settings - Fork 60
fix: better list children rendering logic #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eszlamczyk
merged 19 commits into
main
from
fix/243/better-list-children-rendering-logic
Jul 7, 2026
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e231750
fix: iosv1
eszlamczyk 23ef095
fix: android v1
eszlamczyk bc0e048
feat: temporary apps showcase
eszlamczyk 2a01bc6
test: maestro tests
eszlamczyk 434ffff
Merge branch 'main' into fix/243/better-list-children-rendering-logic
eszlamczyk 7882e5d
fix: updated screenshots
eszlamczyk 37fb840
test: maestro screenshots for android
eszlamczyk 774fa4a
refactor: move stack operations to abstract class
eszlamczyk 0a20b7b
fix: screenshots
eszlamczyk 87ea52c
fix: restored bad screenshots
eszlamczyk 6c8ed9b
feat: tight paragraph on parser
eszlamczyk d830db8
refactor: cleaner ios list/nested elements architecture
eszlamczyk aaf2ccf
refactor: cleaner android list/nested items architecture
eszlamczyk 0efc880
test: maestro tests
eszlamczyk 9df6b11
feat: updated test panel with additional examples
eszlamczyk 7dfd625
docs: added informations to documentation;
eszlamczyk 98b2f47
fix: finall fixes
eszlamczyk d1d0c58
fix: copilot review
eszlamczyk a6c7d23
fix: apply cr comments
eszlamczyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
33 changes: 33 additions & 0 deletions
33
.../enrichedMarkdownText/flows/advanced/block_elements/list_code_block_first_combo_test.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| appId: swmansion.enriched.markdown.example | ||
| tags: | ||
| - block | ||
| - advanced | ||
| - list | ||
| - code_block | ||
| --- | ||
| # checks list items whose first (and only) child is a fenced code block — | ||
| # the marker must still be drawn in the gutter next to the code block. | ||
| - launchApp | ||
|
|
||
| - runFlow: | ||
| file: '../../../../subflows/move_to_playground.yaml' | ||
|
|
||
| - runFlow: | ||
| file: '../../../subflows/set_enriched_text_value.yaml' | ||
| env: | ||
| VALUE: | | ||
| 1. ``` | ||
| npm install | ||
| ``` | ||
| 2. ``` | ||
| gh auth login | ||
| ``` | ||
|
|
||
| - ``` | ||
| echo bullet | ||
| ``` | ||
|
|
||
| - runFlow: | ||
| file: '../../../subflows/capture_or_assert_screenshot.yaml' | ||
| env: | ||
| SCREENSHOT_NAME: 'list_code_block_first_combo_display' |
40 changes: 40 additions & 0 deletions
40
.../enrichedMarkdownText/flows/advanced/block_elements/list_code_block_loose_combo_test.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| appId: swmansion.enriched.markdown.example | ||
| tags: | ||
| - block | ||
| - advanced | ||
| - list | ||
| - code_block | ||
| - text | ||
| --- | ||
| # checks a "loose" ordered list where items and their fenced code blocks | ||
| # are separated by blank lines (each item wraps its content in Paragraph nodes). | ||
| - launchApp | ||
|
|
||
| - runFlow: | ||
| file: '../../../../subflows/move_to_playground.yaml' | ||
|
|
||
| - runFlow: | ||
| file: '../../../subflows/set_enriched_text_value.yaml' | ||
| env: | ||
| VALUE: | | ||
| 1. Install via npm: | ||
| ``` | ||
| npm install | ||
| ``` | ||
|
|
||
| 2. Authenticate with GitHub: | ||
| ``` | ||
| gh auth login | ||
| ``` | ||
|
|
||
| This opens your browser for OAuth. Once authorized, tokens are stored locally at `~/.config/gh/tokens.json`. | ||
|
|
||
| 3. Verify the connection: | ||
| ``` | ||
| gh repo list | ||
| ``` | ||
|
|
||
| - runFlow: | ||
| file: '../../../subflows/capture_or_assert_screenshot.yaml' | ||
| env: | ||
| SCREENSHOT_NAME: 'list_code_block_loose_combo_display' |
37 changes: 37 additions & 0 deletions
37
.../enrichedMarkdownText/flows/advanced/block_elements/list_code_block_tight_combo_test.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| appId: swmansion.enriched.markdown.example | ||
| tags: | ||
| - block | ||
| - advanced | ||
| - list | ||
| - code_block | ||
| - text | ||
| --- | ||
| # checks a "tight" ordered list where items and their fenced code blocks | ||
| # are directly adjacent (no blank lines between). | ||
| - launchApp | ||
|
|
||
| - runFlow: | ||
| file: '../../../../subflows/move_to_playground.yaml' | ||
|
|
||
| - runFlow: | ||
| file: '../../../subflows/set_enriched_text_value.yaml' | ||
| env: | ||
| VALUE: | | ||
| 1. Install via npm: | ||
| ``` | ||
| npm install | ||
| ``` | ||
| 2. Authenticate with GitHub: | ||
| ``` | ||
| gh auth login | ||
| ``` | ||
| This opens your browser for OAuth. Once authorized, tokens are stored locally at `~/.config/gh/tokens.json`. | ||
| 3. Verify the connection: | ||
| ``` | ||
| gh repo list | ||
| ``` | ||
|
|
||
| - runFlow: | ||
| file: '../../../subflows/capture_or_assert_screenshot.yaml' | ||
| env: | ||
| SCREENSHOT_NAME: 'list_code_block_tight_combo_display' |
27 changes: 27 additions & 0 deletions
27
...tro/enrichedMarkdownText/flows/advanced/block_elements/list_sublist_first_combo_test.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| appId: swmansion.enriched.markdown.example | ||
| tags: | ||
| - block | ||
| - advanced | ||
| - list | ||
| - text | ||
| --- | ||
| # checks a list item whose first child is a nested sublist — both the outer | ||
| # and inner markers must be drawn on the shared first line, at their own gutters. | ||
| - launchApp | ||
|
|
||
| - runFlow: | ||
| file: '../../../../subflows/move_to_playground.yaml' | ||
|
|
||
| - runFlow: | ||
| file: '../../../subflows/set_enriched_text_value.yaml' | ||
| env: | ||
| VALUE: | | ||
| 1. | ||
| - alpha | ||
| - beta | ||
| 2. gamma | ||
|
|
||
| - runFlow: | ||
| file: '../../../subflows/capture_or_assert_screenshot.yaml' | ||
| env: | ||
| SCREENSHOT_NAME: 'list_sublist_first_combo_display' |
29 changes: 29 additions & 0 deletions
29
...o/enrichedMarkdownText/flows/advanced/block_elements/task_list_code_block_combo_test.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| appId: swmansion.enriched.markdown.example | ||
| tags: | ||
| - block | ||
| - advanced | ||
| - list | ||
| - task_list | ||
| - code_block | ||
| --- | ||
| # checks a checked task item containing a fenced code block — the checked | ||
| # text decorations (strikethrough / color) must not bleed into the code block. | ||
| - launchApp | ||
|
|
||
| - runFlow: | ||
| file: '../../../../subflows/move_to_playground.yaml' | ||
|
|
||
| - runFlow: | ||
| file: '../../../subflows/set_enriched_text_value.yaml' | ||
| env: | ||
| VALUE: | | ||
| - [x] setup complete | ||
| ``` | ||
| npm i | ||
| ``` | ||
| - [ ] still pending | ||
|
|
||
| - runFlow: | ||
| file: '../../../subflows/capture_or_assert_screenshot.yaml' | ||
| env: | ||
| SCREENSHOT_NAME: 'task_list_code_block_combo_display' |
Binary file modified
BIN
+106 Bytes
(100%)
...nrichedMarkdownText/screenshots/android/blockquote_code_block_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-261 Bytes
(99%)
...stro/enrichedMarkdownText/screenshots/android/blockquote_list_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+341 Bytes
(100%)
...ro/enrichedMarkdownText/screenshots/android/header_blockquote_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+170 Bytes
(100%)
...ro/enrichedMarkdownText/screenshots/android/header_code_block_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-181 Bytes
(99%)
.maestro/enrichedMarkdownText/screenshots/android/header_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+232 Bytes
(100%)
.maestro/enrichedMarkdownText/screenshots/android/header_list_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-327 Bytes
(99%)
...tro/enrichedMarkdownText/screenshots/android/header_paragraph_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+60 Bytes
(100%)
.maestro/enrichedMarkdownText/screenshots/android/header_table_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+19.7 KB
...nrichedMarkdownText/screenshots/android/list_code_block_first_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+57.8 KB
...nrichedMarkdownText/screenshots/android/list_code_block_loose_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+57.8 KB
...nrichedMarkdownText/screenshots/android/list_code_block_tight_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.8 KB
...o/enrichedMarkdownText/screenshots/android/list_sublist_first_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-163 Bytes
(99%)
.maestro/enrichedMarkdownText/screenshots/android/math_display_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+117 Bytes
(100%)
.maestro/enrichedMarkdownText/screenshots/android/mixed_nested_list_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-142 Bytes
(100%)
.maestro/enrichedMarkdownText/screenshots/android/nested_blockquote_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-181 Bytes
(99%)
...enrichedMarkdownText/screenshots/android/paragraph_blockquote_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+153 Bytes
(100%)
...enrichedMarkdownText/screenshots/android/paragraph_code_block_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-409 Bytes
(99%)
.maestro/enrichedMarkdownText/screenshots/android/paragraph_math_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+16.1 KB
...enrichedMarkdownText/screenshots/android/task_list_code_block_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+50 Bytes
(100%)
.maestro/enrichedMarkdownText/screenshots/android/thematic_break_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+24.7 KB
...ro/enrichedMarkdownText/screenshots/ios/list_code_block_first_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+47.3 KB
...ro/enrichedMarkdownText/screenshots/ios/list_code_block_loose_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+47.1 KB
...ro/enrichedMarkdownText/screenshots/ios/list_code_block_tight_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+11.3 KB
.maestro/enrichedMarkdownText/screenshots/ios/list_sublist_first_combo_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-121 Bytes
(100%)
.maestro/enrichedMarkdownText/screenshots/ios/nested_blockquote_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+18.6 KB
...tro/enrichedMarkdownText/screenshots/ios/task_list_code_block_combo_display.png
Oops, something went wrong.
Binary file modified
BIN
+19 Bytes
(100%)
.maestro/enrichedMarkdownText/screenshots/ios/task_list_display.png
Oops, something went wrong.
Binary file modified
BIN
+20 Bytes
(100%)
...o/enrichedMarkdownText/screenshots/ios/task_list_ordered_list_combo_display.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.