[All] Security : nullptr checks #5903
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: fix
fredroy
force-pushed
the
fix_vulnerabilities_pointer
branch
from
63d135f to
0b30929
Compare
Contributor
Author
|
[ci-build][with-all-tests] |
bakpaul
reviewed
Jan 30, 2026
Contributor
bakpaul
left a comment
bakpaul
left a comment
There was a problem hiding this comment.
A lot of the checks are made after a dynamic cast from context to node. I don't think this is required. Maybe we could change the cast to a static one ? Because we know that somehow in a sofa simulation a context doesn't live alone and is always actually comming from a Node object.
Comment on lines
+245
to
+246
| if (!context) | ||
| continue; |
Contributor
There was a problem hiding this comment.
Don't we know this is not required ? Maybe here a static_cast would work. Because context is somehow == node no ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dynamic_cast result not checked and some other pointers were not checked
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if