Skip to content

CRE-5836: Remove legacy DAG guards and wasm host options from workflows - #23727

Merged
bolekk merged 1 commit into
developfrom
keystone_wasm_cleanup_3
Sep 14, 2026
Merged

bolekk merged 1 commit into
developfrom
keystone_wasm_cleanup_3

Conversation

@bolekk

@bolekk bolekk commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Prepares chainlink for the removal of the legacy DAG WASM host from chainlink-common (CRE-5836): drops the WithDeterminism() module option, the ModuleConfig Labeler field and the IsLegacyDAG() rejection guards in the syncer handler and standalone engine.

The V2 host has a different random seed based on execution ID. Also V2 user-facing output flows via ExecutionHelper, not labeler.

The IsLegacyDAG() methods on EvictableModule, ConfidentialModule and test fakes are deliberately kept: the pinned chainlink-common still requires them on host.ModuleBase, and they remain harmless (unused extra methods) once the post-cleanup common lands. They are deleted together with the next common pin bump.

See smartcontractkit/chainlink-common#2382

Deployment Validation: Existing canaries.

@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

Prepares chainlink for the removal of the legacy DAG WASM host from
chainlink-common (CRE-5836): drops the WithDeterminism() module option,
the ModuleConfig Labeler field and the IsLegacyDAG() rejection guards in
the syncer handler and standalone engine.

The IsLegacyDAG() methods on EvictableModule, ConfidentialModule and
test fakes are deliberately kept: the pinned chainlink-common still
requires them on host.ModuleBase, and they remain harmless (unused
extra methods) once the post-cleanup common lands. They are deleted
together with the next common pin bump.
@bolekk
bolekk force-pushed the keystone_wasm_cleanup_3 branch from 4dea614 to a04e49e Compare September 11, 2026 22:44
@bolekk
bolekk marked this pull request as ready for review September 11, 2026 22:46
@bolekk
bolekk requested a review from a team as a code owner September 11, 2026 22:46
@trunk-io

trunk-io Bot commented Sep 11, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CCIPTokenTransfer_Solana2Sui_BurnMintTokenPool_ZeroTokenReceiver_Revert Logs ↗︎

View Full Report ↗︎Docs

@cl-sonarqube-production

Copy link
Copy Markdown

@bolekk
bolekk enabled auto-merge September 11, 2026 23:24
@bolekk bolekk changed the title [CRE] Remove legacy DAG guards and wasm host options from workflows CRE-5836: Remove legacy DAG guards and wasm host options from workflows Sep 13, 2026
@bolekk
bolekk added this pull request to the merge queue Sep 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 14, 2026
@bolekk
bolekk added this pull request to the merge queue Sep 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 14, 2026
@bolekk
bolekk added this pull request to the merge queue Sep 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 14, 2026
@bolekk
bolekk added this pull request to the merge queue Sep 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 14, 2026
@bolekk
bolekk added this pull request to the merge queue Sep 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 14, 2026
@bolekk
bolekk added this pull request to the merge queue Sep 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 14, 2026
@bolekk
bolekk added this pull request to the merge queue Sep 14, 2026
Merged via the queue into develop with commit eddf510 Sep 14, 2026
481 of 489 checks passed
@bolekk
bolekk deleted the keystone_wasm_cleanup_3 branch September 14, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants