CRE-6427: Make triggerRegistrationManager thread-safe - #2383
Draft
bolekk wants to merge 1 commit into
Draft
Conversation
Concurrent trigger registrations were serialized by the exclusive lock in atomic*Capability.RegisterTrigger and the single-lock (non-thread-safe) triggerRegistrationManager, so the async RegisterTrigger work on the trigger_publisher side (chainlink#23049) still blocked on this lock and startup registrations were slow. Assign a lock per registration instead of a single lock for the whole manager: the regs map is guarded by a manager mutex while each registration owns its own lock, so (un)registrations of different triggers proceed concurrently and same-trigger lifecycle operations are serialized. RegisterTrigger/UnregisterTrigger now take a read lock on the atomic capability; Update still rebinds registrations under the exclusive write lock. 10 concurrent registrations with a 100ms underlying call drop from ~1.01s (serialized) to ~0.10s.
bolekk
changed the title
Contributor
📊 API Diff Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent trigger registrations were serialized by the exclusive lock in atomic*Capability.RegisterTrigger and the single-lock (non-thread-safe) triggerRegistrationManager, so the async RegisterTrigger work on the trigger_publisher side (chainlink#23049) still blocked on this lock and startup registrations were slow.
Assign a lock per registration instead of a single lock for the whole manager: the regs map is guarded by a manager mutex while each registration owns its own lock, so (un)registrations of different triggers proceed concurrently and same-trigger lifecycle operations are serialized. RegisterTrigger/UnregisterTrigger now take a read lock on the atomic capability; Update still rebinds registrations under the exclusive write lock.