Require Stellar enum presence in proto responses

[Krish-vemula]

Summary

• make Stellar event_type and tx_status proto fields optional
• reject omitted enum fields on inbound conversion
• keep checked enum conversion for unknown values

[github-actions]

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (2)

pkg/chains/stellar.EventInfo (1)

• EventType — Type changed:

  - EventType
  + *EventType
)

pkg/chains/stellar.SubmitTransactionResponse (1)

• TxStatus — Type changed:

  - TxStatus
  + *TxStatus
)

---

📄 View full apidiff report

[Copilot]

🔵 Needs a closer look

It changes proto wire/API semantics and introduces stricter validation that may break older clients that previously omitted these enum fields.

Pull request overview

This PR updates the Stellar gRPC/proto surface so event_type (in EventInfo) and tx_status (in SubmitTransactionResponse) have explicit presence semantics, and tightens proto→domain conversions to reject responses that omit these enums.

Changes:

• Mark EventInfo.event_type and SubmitTransactionResponse.tx_status as optional in stellar.proto (and regenerate Go bindings accordingly).
• Update outbound domain→proto conversions to always set these enum pointers.
• Update inbound proto→domain conversions to error when the enum fields are omitted, while still rejecting unknown/unsupported enum numeric values; add tests for the new “missing enum” cases.

File summaries

File	Description
pkg/chains/stellar/stellar.proto	Makes event_type and tx_status optional to enable presence detection.
pkg/chains/stellar/stellar.pb.go	Regenerated Go protobufs reflecting optional enum presence (pointer fields + presence-aware getters).
pkg/chains/stellar/proto_helpers.go	Enforces required presence on proto→domain conversion; ensures domain→proto sets enum pointers.
pkg/chains/stellar/proto_helpers_test.go	Adds/updates tests for missing enum presence and pointer-based enum fields.

Review details

Files not reviewed (1)

• pkg/chains/stellar/stellar.pb.go: Generated file

• Files reviewed: 3/4 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.