pkg/workflows/dontime: introduce feature flagged fix for sequence number inconsistency - #2361
Draft
jmank88 wants to merge 3 commits into
Draft
pkg/workflows/dontime: introduce feature flagged fix for sequence number inconsistency#2361jmank88 wants to merge 3 commits into
jmank88 wants to merge 3 commits into
Conversation
Contributor
✅ API Diff Results -
|
…ber inconsistency
jmank88
force-pushed
the
CRE-5838-dontime-seqnums
branch
from
September 8, 2026 22:14
01f63a7 to
9cc0558
Compare
jmank88
commented
Sep 8, 2026
bolekk
reviewed
Sep 10, 2026
| @@ -0,0 +1,24 @@ | |||
| package pb | |||
Contributor
Author
There was a problem hiding this comment.
Seemed fitting as a method, but could be a helper func instead 🤷
bolekk
reviewed
Sep 11, 2026
| WorkflowExecutionID: req.WorkflowExecutionID, | ||
| SeqNum: req.SeqNum, | ||
| Timestamp: 0, | ||
| Err: fmt.Errorf("requested seqNum %d for executionID %s is greater than expected based on the max seqNum observed so far %d", |
Contributor
There was a problem hiding this comment.
I don't think we should error here. What if the plugin didn't process all lower seq numbers in the previous round? I thought we would always add all local requests to observation.
| timestampNodePairs = append(timestampNodePairs, timestampNodePair{Timestamp: observation.Timestamp, NodeID: idx}) | ||
| outcome := prevOutcome | ||
|
|
||
| // Compare with prior outcome to ensure DON time never goes backward. |
Contributor
There was a problem hiding this comment.
Shouldn't this check happen earlier, before we go into un/sequencedOutcome() ?
|
|
||
| // sequencedOutcome executed the updated outcome logic to produce a sequenced map of [pb.ObservedDonTimes.TimestampsBySequence]. | ||
| func (p *Plugin) sequencedOutcome(ctx context.Context, outctx ocr3types.OutcomeContext, _ types.Query, aos []types.AttributedObservation, donTime int64) (ocr3types.Outcome, error) { | ||
| observationCounts := map[string]int64{} // counts how many nodes reported where a new DON timestamp might be needed |
Contributor
There was a problem hiding this comment.
nit: comment what is the key in this map
| continue | ||
| } | ||
|
|
||
| if !observation.GetLimitByBatchSizeFlag() { |
Contributor
There was a problem hiding this comment.
hmm I should've cleaned that up. We can assume this is enabled everywhere by now
| observationCounts[id]++ | ||
| } else if requestSeqNum > currSeqNum { | ||
| // This should never happen since we don't include out of sequence requests in the Observation phase | ||
| p.lggr.Errorf("request seqNum %d for executionID %s is greater than the current seqNum %d", |
Contributor
There was a problem hiding this comment.
I don't think it's an error any more. Shouldn't we just process the highest number that we can reach consensus on and allow for gaps? cc @cedric-cordenier if I'm missing something here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/CRE-5838
Supports: