fix: update messages PropType to allow objects#533
Open
takaokouji wants to merge 3 commits intodevelopfrom
Open
fix: update messages PropType to allow objects#533takaokouji wants to merge 3 commits intodevelopfrom
takaokouji wants to merge 3 commits intodevelopfrom
Conversation
- Added src/lib/log-suppression.js to filter out specific console warnings. - Imported suppression logic in main playground entry point and library index. - Warnings suppressed include: - Object freezing is not supported by Opal - Canvas2D willReadFrequently attribute - React defaultProps deprecation (future-proofing) - React unknown prop recognition - Deprecated React lifecycle methods - findDOMNode deprecation - AudioContext user gesture requirement - apple-mobile-web-app-capable meta tag deprecation 🤖 Generated with [Gemini Code](https://gemini.google.com/code) Co-Authored-By: Gemini <noreply@google.com>
- Improve log-suppression to check all console arguments - Add GenerateSW warning to ignoredWarnings - Add mobile-web-app-capable meta tag to address deprecation warning
- Updated 'messages' PropType to allow values that are either strings or objects - This fixes the React PropType warning when opening the connection modal, where format-message transforms message strings into objects. Co-Authored-By: Gemini <noreply@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the React PropType warning 'Invalid prop messages.mesh.sensorValue of type object supplied to Blocks, expected string' that occurs when opening the connection modal.
The warning is caused by the format-message library transforming message strings into objects with a 'message' property and a 'format' function. Updating the PropTypes to allow objects resolves this issue.