Skip to content

improvement(fivetran): use shared filterUndefined and readonly constant lists - #8992

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/fivetran-review-cleanup
Oct 13, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/fivetran-review-cleanup

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Replace the local compactBody helper in the Fivetran tools with the shared filterUndefined from @sim/utils/object (same semantics: drops only undefined keys)
  • Mark the Fivetran block's operation lists, option lists, and PAUSE_ONLY_UPDATE as const, spreading them into condition/required/options and using (X as readonly string[]).includes(op) for membership, matching the Snowflake/QuickBooks/Harmonic blocks
  • No behavior change: regenerated tool metadata and docs are byte-identical

Type of Change

  • Improvement / refactor

Testing

  • Scoped type check of tools/fivetran and the Fivetran block
  • check-block-registry vs staging; targeted audits: canvas-sentences, tool-metadata, docs, integration-catalog, utils, comment-hygiene, tool-request-boundary, tool-param-reachability
  • Full type-check, check:audits, and test suite left to CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 13, 2026 9:35pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 15 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low impact] This PR appears safe to merge; no actionable issues were found.

Summary

This PR replaces Fivetran's local compactBody helper with shared filterUndefined and adds as const to its fixed lists and pause settings.

  • Fivetran tools build request bodies with the shared undefined-value filter.
  • The Fivetran block uses readonly lists for operations and choices.

Reviews (1) · Last reviewed commit: "improvement(fivetran): use shared filter..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit a0526e7 into staging Oct 13, 2026
40 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/fivetran-review-cleanup branch October 13, 2026 21:38

This branch was previously deployed

1 inactive deployment
Preview — 2211ef4a Deployed Oct 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant