feat(projects): move Project membership to the workspace column by mzxchandra · Pull Request #8830 · simstudioai/sim

mzxchandra · 2026-10-09T01:58:30Z

Summary

Prepare the move from project_workspace to workspace.project_id with one authoritative membership representation in each phase. This compatible release continues to work while #8590 performs the backfill and after it retires the connector.

Add nullable membership, the restrictive Project FK, and a concurrent index in SQL 0406, after upstream OAuth 0405. No bulk backfill runs in this release.
Connector-mode writes remain connector-only. The checked singleton selects authority transactionally; column-mode writes use the workspace column and reads fall back to the connector only for unassigned legacy rows.
The shared workspace barrier coordinates the authority switch, including snapshot ordering. Account teardown deletes workspaces before Projects. Public workspace response shapes remain unchanged.
Record the final storage and enforcement decisions in packages/db/PROJECT_MEMBERSHIP.md. Project non-emptiness and archive lifecycle belong to application transactions. Release 2 uses native composite FKs for organization and connected-fork consistency, with no custom integrity/synchronization triggers or artificial Project row updates. project.updated_at remains ordinary metadata.

Rollout and rollback

Deploy this release, then verify that concrete incompatible membership-sensitive requests and independently scheduled workers have drained. The all-at-once application traffic switch stops fresh requests to retired servers; container retention alone is not evidence of a membership writer.

Only then deploy #8590. Its migration switches authority, performs all bounded backfill/reconciliation, validates final constraints, and atomically drops the connector and rollout marker while this release still serves traffic. No new infrastructure maintenance mechanism or third compatibility release is required.

After the authority switch, this release is the oldest supported application rollback. Keep the database changes; do not reset authority or deploy pre-#8830 code. This release recognizes a completed schema without either temporary table by checking required membership and the three validated membership foreign keys. A missing marker in an incomplete schema is an error.

Validation

Current-head focused local proof: three real PostgreSQL application tests passed for marker-free reads/writes, rejection of incomplete schemas, authority barriers, and snapshot ordering; eight billing lock-order unit tests passed. Merged current staging and retained its billing test synchronization fix.

Earlier local Docker/HTTP proof (before marker removal):

This release created and forked in connector mode, leaving workspace columns NULL.
The actual release-2 migration runner preserved those Project assignments, installed the native constraints, retired the connector, and recorded completion while the same release-1 dev server remained running.
Nine HTTP smoke checks then passed on that same server, covering authenticated workspace/Project creation, reads, fork inheritance, subtree disconnection and archival, plus fixture cleanup.
Real account-deletion preview/POST also passed and removed the fixture's workspaces and Projects.

These local requests prove compatibility, not production drain completion. Full CI runs on GitHub Actions; no full local suite was run. Downstream #8609/#8610 still need synchronization with the revised stack and its recorded decisions.

Current hosted status

Head 5dc6f90e5a fixes the real-Drizzle authority result and subquery routing in workspace-move fixtures. All 24 workspace-move tests pass locally. Both Greptile findings were answered individually and resolved. CI and both reviews were retriggered for this head; results remain pending: https://github.com/simstudioai/sim/actions/runs/38085210891.

…pace-column-expand

vercel · 2026-10-09T01:58:38Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Oct 10, 2026 9:29pm UTC

mzxchandra · 2026-10-09T05:42:06Z

@greptile review

mzxchandra · 2026-10-09T05:42:14Z

@cubic review

cubic-dev-ai · 2026-10-09T05:42:19Z

@cubic review

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 25 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

greptile-apps · 2026-10-09T05:50:47Z

Confidence Score: 5/5

[Critical impact] This PR appears safe to merge, with no new actionable issue found.

Summary

This PR prepares Project membership to move from project_workspace to workspace.project_id.

Adds nullable membership, a restrictive foreign key, a concurrent index, and a checked authority marker.
Keeps connector-only writes before cutover. After cutover, reads prefer the column and fall back only for unassigned legacy rows.
Coordinates cutover with workspace locks, deletes workspaces before Projects, and keeps public workspace responses unchanged.
No new actionable issue was found. This review used the full PR diff because the previous and current heads have different merge bases.
mzxchandra accepted the higher-branch creation, error-import, and account-deletion changes as required downstream work before feat: establish shared file ownership foundation #8609/feat(files): add the Project file backend and APIs #8610 ship. Those existing findings were not reposted.
mzxchandra previously accepted temporary fork/disconnect failures during overlap. Connector-only writes now remove the cause of that earlier failure.
Checks were by code inspection; no tests were run during this review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Begin membership transaction] --> B[Hold workspace read lock]
  B --> C{Membership authority}
  C -->|Connector| D[Read and write connector membership]
  C -->|Column| E[Write workspace membership]
  E --> F[Read column; fall back only for NULL legacy rows]
  D --> G[Commit]
  F --> G
  H[Release 2 takes exclusive workspace lock] --> I[Switch authority]
  I --> J[Backfill and validate constraints]
  J --> K[Remove connector and marker atomically]

_{Reviews (22) · Last reviewed commit: "Merge remote-tracking branch 'origin/sta..." · Reviewed by Greptile}

greptile-apps · 2026-10-09T05:51:05Z

Comments Outside Diff

These findings could not be posted inline.

Later releases call removed helper apps/sim/lib/projects/membership.ts:128 ▶

PR feat: establish shared file ownership foundation #8609 and PR feat(files): add the Project file backend and APIs #8610 still import and call createProjectForWorkspace in apps/sim/lib/workspaces/create.ts and their Project fixtures. Removing that export means those callers cannot build against this release's membership module. Update them to create the Project first and write workspace.projectId in the same transaction.

…pace-column-expand

mzxchandra · 2026-10-09T06:46:57Z

The removed-helper warning is a required downstream integration step. #8830 and #8590 use createProjectRecord before inserting workspace.project_id in the same transaction; the connector-based createProjectForWorkspace must not be restored. #8609 and #8610 must merge the final #8590 head and reconcile their creation/fixture callers before merging. Their shared foundation files are still awaiting that parent synchronization, so local feature-specific conversions alone do not establish a green combined stack. Preserve the downstream account-deletion storage cleanup effects and deferred Project deletion when resolving those conflicts.

mzxchandra · 2026-10-09T06:46:59Z

@greptile

mzxchandra · 2026-10-09T06:47:01Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-09T06:47:08Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 26 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

cubic-dev-ai · 2026-10-10T09:23:25Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 34 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

…pace-column-expand # Conflicts: # apps/sim/lib/billing/webhooks/stripe-sync-convergence.integration.ts

mzxchandra · 2026-10-10T20:35:56Z

@greptile Please review current head 467d269, including the staging merge and completed-schema detection that allows PR #8590 to remove the rollout marker while this release remains serving and rollback-compatible.

mzxchandra · 2026-10-10T20:35:57Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-10T20:36:02Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 34 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

mzxchandra · 2026-10-10T20:49:25Z

@greptile Please re-review head 5dc6f90. Both fixture findings are fixed and individually answered; all 24 workspace-move tests pass locally.

mzxchandra · 2026-10-10T20:49:26Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-10T20:49:32Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 34 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

cubic-dev-ai

No issues found across 34 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic}

mzxchandra · 2026-10-10T21:12:54Z

@greptile

mzxchandra · 2026-10-10T21:12:55Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-10T21:13:02Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 34 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

…pace-column-expand

mzxchandra added 3 commits October 8, 2026 17:50

feat(projects): prepare workspace project column compatibility

5e8380d

test(projects): clean up compatibility fixtures atomically

235d1e2

Merge remote-tracking branch 'origin/staging' into feat/project-works…

e32fda6

…pace-column-expand

mzxchandra mentioned this pull request Oct 9, 2026

feat(projects): enforce Project membership and retire the connector #8590

Draft

mzxchandra added this pull request to stack #8831 October 9, 2026 02:01

vercel Bot deployed to Preview October 9, 2026 02:05 View deployment

mzxchandra added 2 commits October 8, 2026 19:51

feat(projects): move membership to workspace column with rollout bridge

202c28e

Merge staging and order Project column expansion after workflow tests

9a29636

mzxchandra changed the title ~~feat(projects): prepare workspace project column compatibility~~ feat(projects): move Project membership to the workspace column Oct 9, 2026

vercel Bot deployed to Preview October 9, 2026 03:18 View deployment

test(projects): align transfer mocks with workspace membership

d6b7a5d

vercel Bot temporarily deployed to Preview October 9, 2026 03:26 Inactive

improvement(workspaces): present API responses explicitly

031ec26

vercel Bot temporarily deployed to Preview October 9, 2026 04:05 Inactive

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread packages/db/migrations/0404_workspace_project_column.sql Outdated

greptile-apps Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread packages/db/migrations/0404_workspace_project_column.sql Outdated

mzxchandra added 2 commits October 8, 2026 23:35

Merge remote-tracking branch 'origin/staging' into feat/project-works…

49e32c7

…pace-column-expand

fix(projects): support PostgreSQL 16 column migration

4a4b85e

vercel Bot deployed to Preview October 9, 2026 06:50 View deployment

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread packages/db/migrations/0404_workspace_project_column.sql Outdated

cubic-dev-ai Bot reviewed Oct 10, 2026

View reviewed changes

docs(projects): record native constraint rollout decisions

5cd7ada

vercel Bot deployed to Preview October 10, 2026 20:26 View deployment

mzxchandra added 2 commits October 10, 2026 13:32

Merge remote-tracking branch 'origin/staging' into feat/project-works…

1988c88

…pace-column-expand # Conflicts: # apps/sim/lib/billing/webhooks/stripe-sync-convergence.integration.ts

fix(projects): recognize completed rollout without its marker

467d269

cubic-dev-ai Bot reviewed Oct 10, 2026

View reviewed changes

vercel Bot deployed to Preview October 10, 2026 20:41 View deployment

greptile-apps Bot reviewed Oct 10, 2026

View reviewed changes

Comment thread packages/testing/src/mocks/database.mock.ts

Comment thread apps/sim/lib/workspaces/admin-move.test.ts

test(projects): model expansion authority in workspace move fixtures

5dc6f90

vercel Bot temporarily deployed to Preview October 10, 2026 20:48 Inactive

cubic-dev-ai Bot reviewed Oct 10, 2026

View reviewed changes

mzxchandra marked this pull request as ready for review October 10, 2026 20:57

cubic-dev-ai Bot reviewed Oct 10, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview October 10, 2026 21:12 Inactive

cubic-dev-ai Bot reviewed Oct 10, 2026

View reviewed changes

Merge remote-tracking branch 'origin/staging' into feat/project-works…

34798aa

…pace-column-expand

mzxchandra force-pushed the feat/project-workspace-column-expand branch from 744885c to 34798aa Compare October 10, 2026 21:22

mzxchandra merged commit 3492598 into staging Oct 10, 2026
36 of 37 checks passed

vercel Bot deployed to Preview October 10, 2026 21:29 View deployment

mzxchandra deleted the feat/project-workspace-column-expand branch October 10, 2026 21:37

Conversation

mzxchandra commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Rollout and rollback

Validation

Current hosted status

Uh oh!

vercel Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mzxchandra commented Oct 9, 2026

Uh oh!

mzxchandra commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Diagram

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments Outside Diff

Uh oh!

mzxchandra commented Oct 9, 2026

Uh oh!

mzxchandra commented Oct 9, 2026

Uh oh!

mzxchandra commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai Bot commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

mzxchandra commented Oct 10, 2026

Uh oh!

mzxchandra commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mzxchandra commented Oct 10, 2026

Uh oh!

mzxchandra commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

mzxchandra commented Oct 10, 2026

Uh oh!

mzxchandra commented Oct 10, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 10, 2026

Uh oh!

mzxchandra commented Oct 9, 2026 •

edited

Loading

vercel Bot commented Oct 9, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Oct 9, 2026 •

edited

Loading

greptile-apps Bot commented Oct 9, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading