Fix for local packages in nested xcode groups#30
Open
TomaszLizer wants to merge 3 commits intosimonbs:mainfrom
Open
Fix for local packages in nested xcode groups#30TomaszLizer wants to merge 3 commits intosimonbs:mainfrom
TomaszLizer wants to merge 3 commits intosimonbs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have stumbled on issue where dependency-graph was not working for my project.
Afgter debugging in turned out that there were two main reasons:
XCLocalSwiftPackageReference)Causing
Error: The element XCLocalSwiftPackageReference is not supported.orzsh: segmentation faultdependency-graph TestDependency.xcodeproj #25 when running from consoleThis is fixed by bumping XcodeProj to version that supports
XCLocalSwiftPackageReferenceEg
PackageBwhich resides in groupNestedPackageswas recognized other be in<root>/PackageBinstead ofroot/NestedGroup/PackageB.This is fixed by utlising fullPath from XcodeProj.
Some other issues might be related to this fix as well, eg:
Updated tests to reflect those changes - since bug was in live path validation of
XcodeProjectParserLive-> I have added FileSystemLive to two tests to take that part into account.Additionally I have updated main example prioject as well as its copy to reflect those changes in tests.