Skip to content

Handle invalid book id tags more robustly#407

Merged
pmachapman merged 1 commit intomasterfrom
invalid_book_codes
Apr 19, 2026
Merged

Handle invalid book id tags more robustly#407
pmachapman merged 1 commit intomasterfrom
invalid_book_codes

Conversation

@pmachapman
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman commented Apr 16, 2026

Fixes #404


This change is Reviewable

@pmachapman pmachapman requested review from Enkidu93 and ddaspit April 16, 2026 00:42
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.06%. Comparing base (76e65e7) to head (103e346).

Files with missing lines Patch % Lines
src/SIL.Machine/Corpora/UsfmFileTextCorpus.cs 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   73.02%   73.06%   +0.04%     
==========================================
  Files         439      439              
  Lines       36693    36700       +7     
  Branches     5039     5042       +3     
==========================================
+ Hits        26794    26814      +20     
+ Misses       8787     8775      -12     
+ Partials     1112     1111       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@pmachapman pmachapman merged commit aceca12 into master Apr 19, 2026
4 checks passed
@pmachapman pmachapman deleted the invalid_book_codes branch April 19, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle invalid book id tags more robustly

4 participants