Skip to content

Add support for dismissing diagnostics#59

Merged
ddaspit merged 7 commits intomainfrom
dismiss-diagnostic
Mar 2, 2026
Merged

Add support for dismissing diagnostics#59
ddaspit merged 7 commits intomainfrom
dismiss-diagnostic

Conversation

@ddaspit
Copy link
Copy Markdown
Contributor

@ddaspit ddaspit commented Feb 24, 2026

  • Add fingerprint field to Diagnostic interface
  • Add DiagnosticDismissalStore interface and InMemoryDiagnosticDismissalStore implementation
  • Add refresh(uri) method to DiagnosticProvider interface
  • Add dismissDiagnostic method to Workspace
  • Compute SHA-256 fingerprints in DiagnosticFactory from diagnostic code, verse ref, and surrounding context
  • Add Dismiss code action and lynx.dismissDiagnostic command handler in the VS Code server and extension
  • Add JsonFileDiagnosticDismissalStore

This change is Reviewable

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 24, 2026

🦋 Changeset detected

Latest commit: 5e5ae21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sillsdev/lynx-punctuation-checker Minor
@sillsdev/lynx Minor
@sillsdev/lynx-delta Patch
@sillsdev/lynx-usfm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ddaspit
Copy link
Copy Markdown
Contributor Author

ddaspit commented Feb 24, 2026

@benjaminking It would be great if you could review the changes to the punctuation checker in this PR. Let me know if you think the fingerprint that I compute for the punctuation checker is insufficient.

@ddaspit ddaspit requested a review from benjaminking February 24, 2026 20:19
Copy link
Copy Markdown
Collaborator

@benjaminking benjaminking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I can only think of edge cases where this fingerprint wouldn't be sufficient, such as the same content repeated multiple times in one verse. But I can't think of any places where this might actually occur offhand, nor can I think of any better way to handle that case.

:lgtm:

@benjaminking partially reviewed 29 files and made 1 comment.
Reviewable status: 29 of 52 files reviewed, all discussions resolved.

@ddaspit ddaspit merged commit 1d96ae7 into main Mar 2, 2026
1 of 2 checks passed
@ddaspit ddaspit deleted the dismiss-diagnostic branch March 2, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants