Conversation
🦋 Changeset detectedLatest commit: 5e5ae21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@benjaminking It would be great if you could review the changes to the punctuation checker in this PR. Let me know if you think the fingerprint that I compute for the punctuation checker is insufficient. |
benjaminking
left a comment
There was a problem hiding this comment.
This looks good to me. I can only think of edge cases where this fingerprint wouldn't be sufficient, such as the same content repeated multiple times in one verse. But I can't think of any places where this might actually occur offhand, nor can I think of any better way to handle that case.
@benjaminking partially reviewed 29 files and made 1 comment.
Reviewable status: 29 of 52 files reviewed, all discussions resolved.
fingerprintfield toDiagnosticinterfaceDiagnosticDismissalStoreinterface andInMemoryDiagnosticDismissalStoreimplementationrefresh(uri)method toDiagnosticProviderinterfacedismissDiagnosticmethod toWorkspaceDiagnosticFactoryfrom diagnostic code, verse ref, and surrounding contextlynx.dismissDiagnosticcommand handler in the VS Code server and extensionJsonFileDiagnosticDismissalStoreThis change is