Conversation
…ripts Agent-Logs-Url: https://github.com/sillsdev/TheCombine/sessions/5728e502-781d-41dc-8c28-e5cd70bdd5bf Co-authored-by: imnasnainaec <6411521+imnasnainaec@users.noreply.github.com>
|
@copilot Should |
Agent-Logs-Url: https://github.com/sillsdev/TheCombine/sessions/ff17ac8b-e651-4a8d-a115-6d9fdb971342 Co-authored-by: imnasnainaec <6411521+imnasnainaec@users.noreply.github.com>
|
commit f0c65e75cb: |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
📝 WalkthroughWalkthroughThe changes remove global npm lifecycle script disabling from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4261 +/- ##
=======================================
Coverage 75.94% 75.94%
=======================================
Files 303 303
Lines 11352 11352
Branches 1403 1403
=======================================
Hits 8621 8621
Misses 2330 2330
Partials 401 401
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ignore-scripts=truein.npmrc(added in #4045) inadvertently suppressed the project's ownpre*/post*scripts (e.g.,prefrontend,postlicense-report-backend) in addition to third-party lifecycle hooks.Changes
.npmrc— all install commands that need to block third-party lifecycle scripts already pass--ignore-scriptsexplicitly:package.jsonstart:npm i --ignore-scriptsDockerfile:npm ci --ignore-scriptsnpm ci --ignore-scriptsCOPY .npmrc ./fromDockerfile— file no longer exists--ignore-scriptstonpxinscripts/generate_openapi.py— restores the third-party lifecycle script protection previously provided by.npmrcDevin review: https://app.devin.ai/review/sillsdev/TheCombine/pull/4261
This change is
Summary by CodeRabbit
This change is