[ReviewEntries > Cells] Don't require function for non-editable cells#4259
[ReviewEntries > Cells] Don't require function for non-editable cells#4259imnasnainaec wants to merge 1 commit intomasterfrom
Conversation
📝 WalkthroughWalkthroughRefactored cell component prop interfaces by extracting read-only properties into a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4259 +/- ##
==========================================
- Coverage 75.94% 66.79% -9.15%
==========================================
Files 303 246 -57
Lines 11352 6274 -5078
Branches 1403 787 -616
==========================================
- Hits 8621 4191 -4430
+ Misses 2330 1824 -506
+ Partials 401 259 -142
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/components/DataEntry/DataEntryTable/NewEntry/VernDialog.tsxuses bothDomainsCellandPartOfSpeechCell, which was overlooked in #4217.This change is
Summary by CodeRabbit