Load bids from db if bid is missing - #9979
Closed
pawanjay176 wants to merge 1 commit into
Closed
pawanjay176 wants to merge 1 commit into
pawanjay176 wants to merge 1 commit into
Conversation
|
Some required checks have failed. Could you please take a look @pawanjay176? 🙏 |
mergify
Bot
added
waiting-on-author
Member
|
Nice catch! we may just want to throw the whole block in the pending payload cache see this issue: #9975 might be a bit less code churn if we did it in this PR, though it is a bit out of scope |
Member
Author
|
There's already 9940. So gonna merge that one and close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
On devnet 9, restarts and cache eviction removed payload bids from the pending cache. This resulted in
MissingBiderrors during envelope and column processing causing repeated lookup failures.This fix loads missing bids from the stored blocks in the db if a cache miss occurs instead of rejecting the envelope/column.
Moved the
load_gloas_payload_bidto beacon_chain as that seemed like a more natural place for it after this refactor.