Skip to content

Stop external-builder envelope 404 after block publication - #9948

Closed
jimmygchen wants to merge 14 commits into
sigp:stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620from
jimmygchen:fix-external-builder-envelope-404
Closed

Stop external-builder envelope 404 after block publication#9948
jimmygchen wants to merge 14 commits into
sigp:stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620from
jimmygchen:fix-external-builder-envelope-404

Conversation

@jimmygchen

@jimmygchen jimmygchen commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

After publishing a Gloas beacon block selected from an external builder, the validator client immediately fetches the payload envelope from its beacon node. That endpoint only serves locally built envelopes, so it returns 404 before the selected builder publishes its envelope. The block still lands, but the validator client reports Error whilst producing block.

The validator client now fetches, signs, and publishes an envelope only when the selected bid has builder_index == BUILDER_INDEX_SELF_BUILD. For an external builder, it stops after publishing the signed beacon block.

ethDreamer and others added 4 commits August 26, 2026 14:12
@ethDreamer
Add Gloas bid selection, block production, and bid gossip processing …
eb37595 
…(Gloas builder API 3/5)

Third PR of the Gloas builder API stack:

- beacon_chain: direct builder bid verification (spawned on the blocking
  executor), gossip-bid refinements, wei-domain bid selection
  (`BidCandidate`/`BidSource`), and Gloas block production that assembles
  local, gossip, and direct-builder candidates
- network: process payload-bid and proposer-preference gossip, including the
  new `PayloadBidError` variants
- client: construct the `Builders` service when the Gloas fork is scheduled
  and wire it into the beacon chain

The HTTP API still serves `GET` produceBlockV4 at this point; the `POST`
conversion and the `Eth-Builder-Url` round-trip land in the next PR.

Change-Id: Ieccaee5db81bf871c19cef1b79fc48283be9dd51
@ethDreamer
Convert produceBlockV4 to POST and round-trip Eth-Builder-Url (Gloas …
99bddcf 
…builder API 4/5)

Fourth PR of the Gloas builder API stack (beacon-APIs sigp#630):

- convert `/eth/v4/validator/blocks/{slot}` to POST with an optional
  `BuilderConfig` body (min_bid, builder_boost_factor, direct builders)
- add `POST /eth/v1/validator/builder_preferences` for forwarding signed
  builder preferences
- set `Eth-Builder-Url` on produceBlockV4 responses when a direct-builder bid
  wins, accept it on `POST /eth/v2/beacon/blocks`, and forward the signed
  block to that builder

The validator client still uses the legacy GET methods at this point; it
migrates in the final PR of this stack.

Change-Id: I0ad30b8f36ad9b588ea1a0398220f92c9597bb95
@ethDreamer
Migrate the validator client to the Gloas builder API (Gloas builder …
44f4424 
…API 5/5)

Final PR of the Gloas builder API stack:

- sign builder request-auth and preferences (REQUEST_AUTH signing domain,
  web3signer message type)
- add the builder configuration store (`builder_definitions.yml`) and book
  documentation
- add the builder-preferences service and switch block production to
  `POST` produceBlockV4 with a `BuilderConfig` body, threading the
  `Eth-Builder-Url` header through block publication
- remove the now-unused legacy `GET` produceBlockV4 client methods

Change-Id: Iaeeaf6205a024e4fb9fd11aae6ac6a75978a8320
@jimmygchen
Skip envelope fetch for external builder blocks
9121df2 
Changes:
Skip validator payload-envelope handling after external-builder block publication.
Cover self-build and external-builder envelope behaviour.
@jimmygchen
jimmygchen marked this pull request as ready for review August 31, 2026 07:15
@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Aug 31, 2026
@ethDreamer
ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 44f4424 to 17bcbc2 Compare September 1, 2026 17:18
@ethDreamer
ethDreamer requested a review from jxs as a code owner September 1, 2026 17:18
@mergify

mergify Bot commented Sep 1, 2026

Copy link
Copy Markdown

This pull request has merge conflicts. Could you please resolve them @jimmygchen? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 1, 2026
@ethDreamer
ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 17bcbc2 to 7c1ffce Compare September 1, 2026 18:32
shane-moore
shane-moore reviewed Sep 2, 2026
View reviewed changes
Comment thread validator_client/validator_services/src/block_service.rs Outdated
Comment on lines +602 to +603
publish_envelope =
signed_execution_payload_bid.message.builder_index == BUILDER_INDEX_SELF_BUILD;

This comment was marked as resolved.

Sign in to view

This was referenced Sep 2, 2026
Open
Merged
@ethDreamer
ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 7c1ffce to 58eedb5 Compare September 2, 2026 15:53
@shane-moore shane-moore mentioned this pull request Sep 2, 2026
Merged
@ethDreamer
ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch 2 times, most recently from 2c3656e to 39cf3c2 Compare September 3, 2026 21:03
@ethDreamer
Add Gloas bid selection, block production, and bid gossip processing …
74a86e2 
…(Gloas builder API 3/5)

Third PR of the Gloas builder API stack:

- beacon_chain: direct builder bid verification (spawned on the blocking
  executor), gossip-bid refinements, wei-domain bid selection
  (`BidCandidate`/`BidSource`), and Gloas block production that assembles
  local, gossip, and direct-builder candidates
- network: process payload-bid and proposer-preference gossip, including the
  new `PayloadBidError` variants
- client: construct the `Builders` service when the Gloas fork is scheduled
  and wire it into the beacon chain

The HTTP API still serves `GET` produceBlockV4 at this point; the `POST`
conversion and the `Eth-Builder-Url` round-trip land in the next PR.

Change-Id: Ieccaee5db81bf871c19cef1b79fc48283be9dd51
@ethDreamer
Convert produceBlockV4 to POST and round-trip Eth-Builder-Url (Gloas …
c9970db 
…builder API 4/5)

Fourth PR of the Gloas builder API stack (beacon-APIs sigp#630):

- convert `/eth/v4/validator/blocks/{slot}` to POST with an optional
  `BuilderConfig` body (min_bid, builder_boost_factor, direct builders)
- add `POST /eth/v1/validator/builder_preferences` for forwarding signed
  builder preferences
- set `Eth-Builder-Url` on produceBlockV4 responses when a direct-builder bid
  wins, accept it on `POST /eth/v2/beacon/blocks`, and forward the signed
  block to that builder

The validator client still uses the legacy GET methods at this point; it
migrates in the final PR of this stack.

Change-Id: I0ad30b8f36ad9b588ea1a0398220f92c9597bb95
@ethDreamer
Migrate the validator client to the Gloas builder API (Gloas builder …
9abe9a1 
…API 5/5)

Final PR of the Gloas builder API stack:

- sign builder request-auth and preferences (REQUEST_AUTH signing domain,
  web3signer message type)
- add the builder configuration store (`builder_definitions.yml`) and book
  documentation
- add the builder-preferences service and switch block production to
  `POST` produceBlockV4 with a `BuilderConfig` body, threading the
  `Eth-Builder-Url` header through block publication
- remove the now-unused legacy `GET` produceBlockV4 client methods

Change-Id: Iaeeaf6205a024e4fb9fd11aae6ac6a75978a8320
@ethDreamer
ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 39cf3c2 to 9abe9a1 Compare September 3, 2026 22:40
@ovidiu-ssv-labs ovidiu-ssv-labs mentioned this pull request Sep 7, 2026
Closed
@ethDreamer
ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 9abe9a1 to 58fba0d Compare September 8, 2026 17:21
@ethDreamer
Convert produceBlockV4 to POST and round-trip Eth-Builder-Url (Gloas …
a03f186 
…builder API 4/5)

Fourth PR of the Gloas builder API stack (beacon-APIs sigp#630):

- convert `/eth/v4/validator/blocks/{slot}` to POST with an optional
  `BuilderConfig` body (min_bid, builder_boost_factor, direct builders)
- add `POST /eth/v1/validator/builder_preferences` for forwarding signed
  builder preferences
- set `Eth-Builder-Url` on produceBlockV4 responses when a direct-builder bid
  wins, accept it on `POST /eth/v2/beacon/blocks`, and forward the signed
  block to that builder

The validator client still uses the legacy GET methods at this point; it
migrates in the final PR of this stack.

Change-Id: I0ad30b8f36ad9b588ea1a0398220f92c9597bb95
@ethDreamer
Migrate the validator client to the Gloas builder API (Gloas builder …
2a6fc09 
…API 5/5)

Final PR of the Gloas builder API stack:

- sign builder request-auth and preferences (REQUEST_AUTH signing domain,
  web3signer message type)
- add the builder configuration store (`builder_definitions.yml`) and book
  documentation
- add the builder-preferences service and switch block production to
  `POST` produceBlockV4 with a `BuilderConfig` body, threading the
  `Eth-Builder-Url` header through block publication
- remove the now-unused legacy `GET` produceBlockV4 client methods

Change-Id: Iaeeaf6205a024e4fb9fd11aae6ac6a75978a8320
@ethDreamer
ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 58fba0d to 2a6fc09 Compare September 8, 2026 22:42
@jimmygchen jimmygchen added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 9, 2026
@ethDreamer
ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch from 2a6fc09 to a434c7d Compare September 9, 2026 14:33
@mergify

mergify Bot commented Sep 9, 2026

Copy link
Copy Markdown

This pull request has merge conflicts. Could you please resolve them @jimmygchen? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 9, 2026
@ethDreamer
ethDreamer force-pushed the stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620 branch 3 times, most recently from dfe9d87 to b050112 Compare September 17, 2026 22:28
@jimmygchen jimmygchen changed the title Stop external-builder envelope 404 after block publication Validator client signs pre-Gloas blocks during Gloas proposals Sep 18, 2026
@jimmygchen jimmygchen changed the title Validator client signs pre-Gloas blocks during Gloas proposals Stop external-builder envelope 404 after block publication Sep 18, 2026
@jimmygchen

jimmygchen commented Sep 18, 2026

Copy link
Copy Markdown
Member Author

Closing this as the external-builder envelope fix has been included in #9807.

@jimmygchen jimmygchen closed this Sep 18, 2026
@jimmygchen
jimmygchen deleted the fix-external-builder-envelope-404 branch September 18, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethDreamer ethDreamer Awaiting requested review from ethDreamer
@jxs jxs Awaiting requested review from jxs
1 more reviewer
@shane-moore shane-moore shane-moore left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

gloas waiting-on-author The reviewer has suggested changes and awaits thier implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jimmygchen @shane-moore @ethDreamer