Skip to content

Fix temp git clones clutter issue.#845

Open
BoubQC wants to merge 1 commit intoshotgunsoftware:masterfrom
BoubQC:master
Open

Fix temp git clones clutter issue.#845
BoubQC wants to merge 1 commit intoshotgunsoftware:masterfrom
BoubQC:master

Conversation

@BoubQC
Copy link
Copy Markdown

@BoubQC BoubQC commented Mar 23, 2022

Use filesystem.safe_delete_folder instead of shutil.rmtree since the later doesn't delete read-only files.

Use filesystem.safe_delete_folder instead of shutil.rmtree since the later didn't delete read-only files.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.82%. Comparing base (4f3880b) to head (e74fe51).
⚠️ Report is 180 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4f3880b) and HEAD (e74fe51). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (4f3880b) HEAD (e74fe51)
19 8
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
- Coverage   79.38%   72.82%   -6.56%     
==========================================
  Files         177      177              
  Lines       19302    19302              
==========================================
- Hits        15322    14056    -1266     
- Misses       3980     5246    +1266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@staceyoue staceyoue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants