Skip to content

feat(localization): add Japanese language pack - #19

Merged
shlifedev merged 1 commit into
mainfrom
feat/japanese-localization
Nov 4, 2026
Merged

shlifedev merged 1 commit into
mainfrom
feat/japanese-localization

Conversation

@shlifedev

Copy link
Copy Markdown
Owner

Adds 日本語 (ja) to the language selector in Stranded II and Extended, with all 2,834 shared catalog keys covering menus, adventure dialogue, items, crafting, editor help, QOL, and developer controls. Language changes continue to take effect after restarting.

  • Preserves fixed keys, placeholder counts, localization references, formatting markers, executable script strings, resource paths, and intentional fictional dialogue. Quest quantities, directions, and item terminology were checked against the source. Keyboard keys, compass directions, inventory keys, and fishing actions retain their distinct meanings.
  • Adds Noto Sans JP for Japanese glyph forms through the existing language-font preparation path. The font, original OFL license, and attribution notice have pinned checksums; preparation reuses a verified offline cache and installs the notices. The upstream license is retained verbatim, including its existing trailing space.
  • Extends the actual Blitz localization checks for Japanese selection, restart, UTF-8 values, label disambiguation, bound variables, and English fallback. Adds Japanese developer controls to the existing Unicode regression test. Updates the English/Korean localization guide and bundled-language instructions.

Validation completed on macOS ARM64:

  • Complete key coverage, matching placeholder/reference/format-marker counts for both editions, preserved executable strings, and UTF-8 without BOM.
  • dev.py localize and dev.py localize --edition extended passed in the separate worktree using verified original font resources. All five language packs contain 3,215 glyphs with no missing glyphs. All Japanese catalog characters are covered by Noto Sans JP; the Korean language name uses the existing fallback. Generated Japanese bitmap text was visually inspected.
  • Built the actual native Blitz compiler and console runtime. The localization fixture from verify.py passed 74 checks per edition with separate classic/Extended catalog copies. Only the fixture's APPDIR initialization was adapted to an explicit test directory for the macOS console runtime. FPS/display settings were preserved.
  • Five font-download/cache regression tests, one developer-catalog Unicode test, and 47 CI packaging/release tests passed.
  • Prepared language registries, catalogs, glyph inventories, fallback TTFs, installed font notices, JSON, documentation links/navigation/synchronization hashes, and whitespace checks passed. The whitespace check excludes the verbatim upstream OFL file. The original worktree and user-maintained README-ko.md are unchanged.

Still requires platform/gameplay verification: full Windows build/check for both editions, macOS app and web/browser builds, and in-game Japanese wrapping, clipping, and adventure progression. The native console checks and font-atlas preview do not establish those results.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T10:36:27.315316Z cae7254 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@shlifedev
shlifedev merged commit f7d6aaa into main Nov 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant