Repository navigation
feat(localization): add Japanese language pack - #19
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 日本語 (
ja) to the language selector in Stranded II and Extended, with all 2,834 shared catalog keys covering menus, adventure dialogue, items, crafting, editor help, QOL, and developer controls. Language changes continue to take effect after restarting.Validation completed on macOS ARM64:
dev.py localizeanddev.py localize --edition extendedpassed in the separate worktree using verified original font resources. All five language packs contain 3,215 glyphs with no missing glyphs. All Japanese catalog characters are covered by Noto Sans JP; the Korean language name uses the existing fallback. Generated Japanese bitmap text was visually inspected.verify.pypassed 74 checks per edition with separate classic/Extended catalog copies. Only the fixture's APPDIR initialization was adapted to an explicit test directory for the macOS console runtime. FPS/display settings were preserved.README-ko.mdare unchanged.Still requires platform/gameplay verification: full Windows build/check for both editions, macOS app and web/browser builds, and in-game Japanese wrapping, clipping, and adventure progression. The native console checks and font-atlas preview do not establish those results.