Skip to content

fix: resolve lines.indexOf bug and safe string replacement pattern bugs in scripts #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shinpr merged 1 commit into from
Jun 24, 2026
+7 −4
Merged

fix: resolve lines.indexOf bug and safe string replacement pattern bugs in scripts #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/check-skills-index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@ function parseSkillsIndex(content) {
let currentSkill = null
let inSections = false

for (const line of lines) {
for (let i = 0; i < lines.length; i++) {
const line = lines[i]
const skillMatch = /^ {2}([\w-]+):\s*$/.exec(line)
if (skillMatch) {
currentSkill = skillMatch[1]
skills[currentSkill] = { sections: [], lineNumber: lines.indexOf(line) + 1 }
skills[currentSkill] = { sections: [], lineNumber: i + 1 }
inSections = false
continue
}
Expand Down
6 changes: 4 additions & 2 deletions scripts/sync-plugins.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,10 @@ function injectDeprecationNotice(content, notice, label) {
if (currentDesc.startsWith(notice)) {
return content
}
const newFm = fm.replace(/^description:[ \t]*(.*)$/m, `description: ${notice}${currentDesc}`)
return content.replace(fmMatch[0], `---\n${newFm}\n---`)
const newFm = fm.replace(/^description:[ \t]*(.*)$/m, (_, matchedDesc) => {
return `description: ${notice}${matchedDesc}`
})
return content.replace(fmMatch[0], () => `---\n${newFm}\n---`)
}

async function loadLocalPlugins() {
Expand Down