Consolidate font model into shift-font#57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the Rust font model around
shift-fontand removes the oldshift-edit/shift-irsplit.shift-fontshift-wireshift-fontGlyphLayerRefmutation targetsWhy
This gives the next workspace/store work a cleaner base:
shift-fontis now the first-class object model, bridge mutation no longer depends on hidden native session state, and renderer selection stays explicit.Validation
cargo check --workspacecargo test --workspacepnpm typecheckpnpm --filter shift-bridge run testpnpm --filter @shift/desktop test -- Glyph.test.ts variation.test.ts SourceEditDraft.test.ts ApplyPositionPatchCommand.test.tsNotes
python3 scripts/context-drift-check.pywas not run because the local Python environment is missingmarkdown_it.