Update JSON - #53
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the SwiftPM dependency on shareup/json-apple to the 2.x line (per the PR description’s breaking behavior around nil assignment in JSON subscripts) and refreshes CI to run against the newer macOS/Xcode toolchain.
Changes:
- Bump
shareup/json-appledependency from1.4.1to2.0.0in SwiftPM. - Update
Package.resolvedto thejson-apple2.0.0revision. - Move CI to
macos-26and select Xcode26.5.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Package.swift | Updates json-apple dependency requirement to from: "2.0.0". |
| Package.resolved | Locks json-apple to the 2.0.0 revision/version. |
| .github/workflows/ci.yml | Updates runner image to macos-26 and selects Xcode 26.5 for tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
11
to
+12
| - name: Select Xcode 26 | ||
| run: sudo xcode-select -s /Applications/Xcode_26.3.app | ||
| run: sudo xcode-select -s /Applications/Xcode_26.5.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only meaningful breaking change between JSON 1.4.1 and 2.0.0 is that assigning
nilthrough aJSONdictionary subscript now stores JSONnullinstead of removing the key. Consumers of this library who relied on the old behavior should now callremoveValue(forKey:)before passing the payload.