Add modal settings page to control brightness, visibility, and which buttons appear in the control window#68
Conversation
Previously, only ExcludeFromCapture was saved to settings.json. Brightness, color temperature, and on/off state reset to defaults on every app restart. Changes: - AppSettings: add IsLightOn, Brightness, and ColorTemperature properties - MainWindow: read persisted values after loading settings in constructor - MainWindow: save settings after every brightness, color temp, or toggle change - Window_Loaded: apply persisted opacity, color temperature, and visibility No breaking changes - existing settings.json files gain the new fields with their default values (IsLightOn=true, Brightness=1.0, ColorTemperature=0.5). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Thanks for this, Garrett — the settings window is a useful direction, and I like the idea of making brightness/color/exclude/buttons discoverable instead of only toolbar/hotkey driven. I took a deep pass over this alongside the persistence work and I don't want to merge it as-is yet. Could you please rebase after the current settings-persistence changes land and tighten up the following items? Required before merge
Manual validation I would like before mergePlease include a short test note covering:
This is close, but because it touches user-visible WPF behavior and overlaps with persisted settings, I want it rebased and manually smoke-tested rather than merging the current branch directly. |
cc99ed0 to
45511b4
Compare
@shanselman I've updated and confirmed the manual validation before merge for all of the smoke testing on the local build. I have confirmed all of the above, except for the release build as I don't want to push a tag to kick off a release from a topic branch) Thanks! Happy to make more changes and test more things as needed/requested. |
Add Settings Window
Adds a new Settings window accessible via a gear button (⚙️) on the control bar. The settings window opens as a modal dialog and provides fine-grained controls that go beyond the toolbar buttons.
New Settings Window Features
Changes
Screenshots
Control Window with various settings disabled/enabled
Without brightness
Without warmth
Without monitor control
Without any