build: Ignore CLANGFLAGS#732
Draft
jschwe wants to merge 1 commit intoservo:mainfrom
Draft
Conversation
CLANGFLAGS was only applied to bindgen. cc-rs is not documented to use it, and SM also doesn't reference it. In servo I also couldn't see us setting this variable. This is a preperation for unifying our common build flags across cc-rs, SM build and bindgen. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Member
Author
|
I'm not sure if it's worth it to merge this standalone, or if I should just put it into the bigger PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLANGFLAGS was only applied to bindgen.
cc-rs is not documented to use it, and SM also doesn't reference it. In servo I also couldn't see us setting this variable. This is a preperation for unifying our common build flags across cc-rs, SM build and bindgen.
Testing: Describe how this pull request is tested or why it doesn't require tests