Merged
Conversation
Methods defined inside doctests have __globals__ pointing to the doctest globs dict. When called from within a Zope request handler, Python builtins are not resolved, causing NameError for True/False. Explicitly bind True and False into the doctest namespace before the adapter class definitions so they are found as globals at call time. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The doctest framework clears the globs dict after users.rst finishes, but DummyUserInfoAdapter stays registered in the global site manager. When auth.rst runs next and triggers a login, to_dict.__globals__ points to the cleared dict where True is no longer defined. Use (1 == 1) instead, which evaluates without a name lookup. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The buildout.base.cfg has auto-checkout=* which caused mr.developer to checkout senaite.jsonapi from branch=2.x to src/senaite.jsonapi/, overriding the current branch checkout in '.'. Override auto-checkout to list all packages except senaite.jsonapi so that 'develop = .' uses the current branch's code for tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR allows to fetch multiple items in one request by their UIDs
Current behavior before PR
GET /analysis/uid1?complete=1
GET /analysis/uid2?complete=1
GET /analysis/uid3?complete=1
Desired behavior after PR is merged
GET /analysis?uids=uid1,uid2,uid3&complete=1
--
I confirm I have tested the PR thoroughly and coded it according to PEP8
standards.