fix: isolate memory-mode batches to prevent retry event poisoning#430
Open
MichaelGHSeg wants to merge 1 commit intoe2e-retry-fixesfrom
Open
fix: isolate memory-mode batches to prevent retry event poisoning#430MichaelGHSeg wants to merge 1 commit intoe2e-retry-fixesfrom
MichaelGHSeg wants to merge 1 commit intoe2e-retry-fixesfrom
Conversation
flushData fetched ALL pending events as a single batch. When a failed retry event accumulated with a new non-retryable event, the entire batch was dropped — including events that should have been retried. Add offset parameter to DataStore.fetch and process events in flushAt-sized batches so each batch is independent, matching file mode behavior where each file gets its own upload. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
didiergarcia
approved these changes
Apr 6, 2026
bsneed
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flushDatapreviously fetched ALL pending events as one batch. Failed retry events accumulated with new events, so a single non-retryable (400) event would poison the entire batch and drop events that should have been retried.offsetparameter toDataStore.fetch/MemoryStore/TransientDBand rewroteflushDatato process events influshAt-sized batches with offset tracking, matching file mode's per-file isolation.skipAllBatchesreturns immediately.Test plan
🤖 Generated with Claude Code