Skip to content

ScreenInfo.Density has wrong type #168

Description

@jakekdodd

The Density field on the ScreenInfo struct is typed as an int, but in reality this is often a floating-point value. I believe this was mistyped because the example in the Common Fields spec is—only by coincidence—a whole number.

This leads to json marshaling/unmarshaling errors at runtime:

WARN[0042] error decoding payloadjson: cannot unmarshal number 2.75 into Go struct field ScreenInfo.context.screen.density of type int 

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions