trivial: typos + missing input xml declaration#454
Conversation
Signed-off-by: Julia Vassiliki <julia.vassiliki@unsw.edu.au>
| output = None | ||
| for line in script: | ||
| result, ouput = run_cmd(line, run, output) | ||
| result, output = run_cmd(line, run, output) |
There was a problem hiding this comment.
This doesn't look trivial, it changes actual behaviour, as the output of previous lines isn't fed to run_cmd.
How on Earth could the old code work?
There was a problem hiding this comment.
It looks like tbe only time that I can see that ever passes something other than a list of strings is in builds.py which does 'lambda r: SKIP'. I guess nothing uses this previous output feature...?
There was a problem hiding this comment.
I was planning to try to detect things like boot failures based on the output of the previous command, but I don't think I ever got around to actually implementing anything useful there. It might be better to remove the entire feature, but I keep thinking that it might be useful down the road, so I haven't done that yet :-)
In any case it is definitely better to use it correctly, even if it currently doesn't do anything.
| if result != SKIP: | ||
| for line in final_script: | ||
| r, output = run_cmd(line, run, ouput) | ||
| r, output = run_cmd(line, run, output) |
3 participants
Split out from au-ts#1.