Skip to content

Mark non-security md5 usage to allow for compatibility with fips environments - #970

Open
mykaul wants to merge 1 commit into
scylladb:masterfrom
mykaul:cherry-pick-fips-md5
Open

Mark non-security md5 usage to allow for compatibility with fips environments#970
mykaul wants to merge 1 commit into
scylladb:masterfrom
mykaul:cherry-pick-fips-md5

Conversation

@mykaul

@mykaul mykaul commented Aug 9, 2026

Copy link
Copy Markdown

Summary

  • Cherry-pick of apache/cassandra-python-driver@f685c2c
  • Marks the non-security md5 usage in MD5Token.hash_fn with usedforsecurity=False so the driver works in FIPS-enforced Python environments, which reject non-approved hash algorithms unless explicitly marked as not used for security purposes.

Test plan

  • Ran the unit test suite (tests/unit) locally; test_metadata.py passes in full, including all MD5Token/Token tests
  • Remaining failures in the full suite are pre-existing environment gaps (missing optional Cython/Twisted/lz4 dependencies), unrelated to this change

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@mykaul, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 44 minutes

Limit details: You’ve used all 3 included reviews currently available under your plan.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro Plus

Run ID: 7cfbd764-3623-4f53-b2ba-72a2b6072f88

📥 Commits

Reviewing files that changed from the base of the PR and between d940fd5 and b79fe50.

📒 Files selected for processing (1)
  • cassandra/metadata.py
📝 Walkthrough

Walkthrough

MD5Token.hash_fn now calls md5 with usedforsecurity=False. The function retains its existing digest conversion and absolute-value behavior.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the MD5 compatibility change for FIPS environments.
Description check ✅ Passed The description explains the change, its purpose, cherry-pick source, and test results; the main required information is present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

environments

patch by Luke Ratcliffe and Brad Schoening; reviewed by Bret McGuire and Brad Schoening
@mykaul
mykaul force-pushed the cherry-pick-fips-md5 branch from d940fd5 to b79fe50 Compare August 16, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants