fix harmony_integrate TypeError under RMM managed memory - #764
Closed
A-Jolly-Holly wants to merge 4 commits into
Closed
fix harmony_integrate TypeError under RMM managed memory#764A-Jolly-Holly wants to merge 4 commits into
A-Jolly-Holly wants to merge 4 commits into
Conversation
added 2 commits
August 15, 2026 17:20
…ments to match memory kind
A-Jolly-Holly
changed the title
Member
|
@AlexHolly-AllenOps thank you for reporting this. Your fix is technically correct however I relies on a view not beeing looked at. So i made those arrays needed optional. I continued working on this in #766. Youre still credited and also i worked of your branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #763
With a single batch key, the zero-size joint placeholder arrays own no allocation, so they report kDLCUDA while every other argument under rmm managed memory reports kDLCUDAManaged. No clustering_loop overload matches.
Using a zero-length view of cats keeps the memory kind consistent under any allocator. Verified on 0.16.1 hardware by applying the change to the installed package and rerunning the repro from 763
Added test_managed_memory.py