[UEPR-483] Action Menu Tests#452
[UEPR-483] Action Menu Tests#452kbangelov wants to merge 22 commits intoscratchfoundation:release/UEPR-297-accessibility-improvementsfrom
Conversation
| expect(document.activeElement).toBe(mainButton); | ||
| }); | ||
|
|
||
| test('tab closes menu and focuses next element', async () => { |
There was a problem hiding this comment.
Maybe we can add a test for shift + tab as well
There was a problem hiding this comment.
Though I did add one, it kept failing if I entered the menu before shift + tab-ing and I couldn't figure out why. Perhaps it's some difference between the user testing library and the real thing. Not sure if it's ok to leave it like this.
There was a problem hiding this comment.
I see that you ended up adding a test for that. Did it start working consistently?
There was a problem hiding this comment.
The one I left, yes. If we add arrow_down to get inside the menu it doesn't perform correctly. Since there were some changes to the base branch since then, I will wait for that one to get merged first and then try again with this test (and check the other ones too).
2 participants
STILL AWAITING MERGE OF #433
Resolves
Part of https://scratchfoundation.atlassian.net/browse/UEPR-483
Proposed Changes
3 Unit tests to test keyboard navigation.
Reason for Changes
Part of Accessibility initiative for Scratch.