QtFRED fix audio handle guards#7575
Open
MjnMixael wants to merge 1 commit into
Open
Conversation
wookieejedi
approved these changes
Jul 7, 2026
github-project-automation
Bot
moved this from Work In Progress (PRs)
to In Review (PRs)
in qtFRED2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The debriefing, command briefing, and campaign editor dialogs in QtFRED would crash if closed without interaction in release builds because the handle int is never initialized and then the later comparison guard is compared against junk data.
Follow the convention of other audio handles, initialize as -1 and compare >= 0 instead.