CI: stop running clang-tidy on QtFRED sources#7566
Closed
Goober5000 wants to merge 1 commit into
Closed
Conversation
ENABLE_QTFRED=OFF, so QtFRED is no longer built. The clang-tidy regex still selected qtfred/ files, causing clang-tidy to parse them with no Qt include paths and fail on <QtCore/QObject>. Drop QtFRED from the regex so tidy only lints what CI builds. We'll need to roll this back once QtFRED is part of workflows again. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Goober5000
added
build
Contributor
|
QtFRED will probably get merged shortly, if you want to wait a bit on this. That way we don't have to yank it back out immediately. |
Contributor
Author
|
Ok, will do |
Contributor
Author
|
No longer needed, since the CI checks in #7432 now pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENABLE_QTFRED=OFF, so QtFRED is no longer built. The clang-tidy regex still selected qtfred/ files, causing clang-tidy to parse them with no Qt include paths and fail on <QtCore/QObject>. Drop QtFRED from the regex so tidy only lints what CI builds.
We'll need to roll this back once QtFRED is part of workflows again.