Add SCITOKENS_SKIP_ONLINE_TESTS env var to disable network-dependent tests#207
Draft
Add SCITOKENS_SKIP_ONLINE_TESTS env var to disable network-dependent tests#207
Conversation
When the SCITOKENS_SKIP_ONLINE_TESTS environment variable is set, all tests that require network connectivity are skipped using GTEST_SKIP(). This allows packagers and CI systems running in offline/network-sandboxed environments to run the test suite without failures. Skipped tests: - KeycacheTest.RefreshTest - KeycacheTest.RefreshInvalid - KeycacheTest.RefreshExpiredTest - KeycacheTest.NegativeCacheTest - KeycacheTest.LoadJwksMissingTest - KeycacheTest.LoadJwksTriggersRefreshWhenStale Co-authored-by: djw8605 <79268+djw8605@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add test parameter to disable online tests for offline testing
Add SCITOKENS_SKIP_ONLINE_TESTS env var to disable network-dependent tests
Mar 7, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a mechanism to skip network-dependent GoogleTest cases in scitokens-cpp when running in offline / network-sandboxed packaging environments.
Changes:
- Introduces
SCITOKENS_SKIP_ONLINE_TESTSenvironment variable gating for online tests viaGTEST_SKIP(). - Applies the skip guard to the six
KeycacheTestcases that depend on external network access.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+682
to
+685
| if (std::getenv("SCITOKENS_SKIP_ONLINE_TESTS")) { | ||
| GTEST_SKIP() << "Skipping online test (SCITOKENS_SKIP_ONLINE_TESTS is " | ||
| "set)"; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packaging tooling (e.g., Gentoo ebuilds) typically runs in network-sandboxed environments. There was no way to skip tests requiring internet connectivity.
SCITOKENS_SKIP_ONLINE_TESTSenvironment variable check usingGTEST_SKIP()to all 6 network-dependent tests intest/main.cpp:KeycacheTest.RefreshTestKeycacheTest.RefreshInvalidKeycacheTest.RefreshExpiredTestKeycacheTest.NegativeCacheTestKeycacheTest.LoadJwksMissingTestKeycacheTest.LoadJwksTriggersRefreshWhenStaleUsage
Produces standard GTest skip output:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.