Skip to content

Enable test.pypi.org upload - #10

Merged
ogrisel merged 1 commit into
scikit-learn:mainfrom
lesteve:test-testpypi
Sep 1, 2026
Merged

Enable test.pypi.org upload#10
ogrisel merged 1 commit into
scikit-learn:mainfrom
lesteve:test-testpypi

Conversation

@lesteve

@lesteve lesteve commented Sep 1, 2026

Copy link
Copy Markdown
Member

Uncomment the relevant section to allow testing uploading on test.pypi.org.

@ogrisel

ogrisel commented Sep 1, 2026

Copy link
Copy Markdown
Member

Let's test this!

@ogrisel
ogrisel merged commit b255d5b into scikit-learn:main Sep 1, 2026
43 checks passed
@lesteve
lesteve deleted the test-testpypi branch September 1, 2026 10:46
@lesteve

lesteve commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

The manually triggered workflow to watch is: https://github.com/scikit-learn/scikit-learn-release/actions/runs/33491499172

Note this take a while, probably because we have 5 macOS concurrent runners and both the PR CI + main CI + manually triggered CI needed to run.

There are 7 CI builds (Python 3.11-3.15 + 2 free-threaded) * 2 (macOS Intel + macOS arm) * 3 (PR CI + main CI + workflow_dispatch) = 42 (the answer to the Ultimate Question of Life, the Universe, and Everything 😉). No wonder it is taking a while.

@ogrisel

ogrisel commented Sep 1, 2026

Copy link
Copy Markdown
Member

So next time we should not forget to cancel the runs we don't care about.

@lesteve

lesteve commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

The macOS Intel also are quite slow (25-30 minutes) https://github.com/scikit-learn/scikit-learn-release/actions/runs/33491499172 but it's the same on the scikit-learn repo https://github.com/scikit-learn/scikit-learn/actions/runs/33467476903, so not related to the scikit-learn-release repo.

The last macOS Intel on Python 3.15 free-threaded is over 32 minutes and only at 60% of the tests https://github.com/scikit-learn/scikit-learn-release/actions/runs/33491499172/job/99803801107 😓

For completeness non-macOS Intel builds are more 10-20 minutes.

@lesteve

lesteve commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

The wheels have been successfully uploaded to test.pypi.org worfklow log + test PyPI release.

I thought there would be some manual approval where we would have to click a button but no. Maybe this only happens when uploading to PyPI not testPyPI?

@ogrisel

ogrisel commented Sep 1, 2026

Copy link
Copy Markdown
Member

I cannot see any manual confirmation step in the wheels.yml workflow file.

@ogrisel

ogrisel commented Sep 1, 2026

Copy link
Copy Markdown
Member

The last macOS Intel on Python 3.15 free-threaded was 45 min. The same build on macOS arm64 is less than 15 min as the other build. So it's probably not a problem of CPython 3.15 or free-threading but rather that the macOS Intel runners are overloaded...

@lesteve

lesteve commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

I triggered another one manually
https://github.com/scikit-learn/scikit-learn-release/actions/runs/33525961034

to:

@lesteve lesteve added this to Labs Sep 1, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Labs Sep 1, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in Labs Sep 1, 2026
@jeremiedbb

Copy link
Copy Markdown
Member

to test the required reviewers functionality where we have to click a button to allow the upload

I approved, which triggered the upload to testpypi. 🎆

I think skip-existing: true will not upload new wheel and the workflow will succeed

Skipping scikit_learn-1.10.dev0-cp311-cp311-macosx_10_9_x86_64.whl because it appears to already exist

the workflow succeeded 👍

@lesteve

lesteve commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

Nice, I was also wondering "where we can we see who approved the workflow manually?" and it took me a while to find it so you need to search for "Deployment Protection rules" towards the bottom of the workflow run log

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants