fix crash on macos on network interface change#225
Conversation
|
Hey, which version are you using? do you happen to have the compiled library for osx ARM anywhere? |
|
|
@WesselVS this crash happens on all platforms I've tried. This includes if I spin up a VM or switch Wifi networks, the app will crash, so this seems invaluable to have |
|
@WesselVS I forgot about your PR but I have added (complementary) functionality in a new PR #259 I think there is also a larger discussion to be had around interface management, this is not a concern hopefully in most lab environments, but if you add mobile devices into the mix suddenly it can become a problem. Some issues can be avoided, e.g. if you are using LSL on a laptop, and it has flaky wifi, you can run the experiment over Ethernet, and only bind LSL to the eth interface. It could be nice to deal with exceptions / interface changes nicely, either with trying to rebind based on the config (with some graceful timeout / check interval) and/or an exposed rebind API method that could be called when required, as long as the app doesn't crash when a change occurs. |
When set_option is called on an unavailable socket, a crash occurs (at least on MacOS). I reproduce this by creating a local outlet, run the GetAllStreams example and unplugging my wire.