UTAPI-122: Fix warp10 client timeouts#1332
Conversation
Hello tmacro,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
| this._requestTimeout = (config && config.requestTimeout) || 60000; | ||
| this._connectTimeout = (config && config.connectTimeout) || 60000; | ||
| this._client = new Warp10(`${proto}://${host}:${port}`, this._requestTimeout, this._connectTimeout); |
There was a problem hiding this comment.
Could we add some comments for the reasoning of choosing this value please for the future us.
There was a problem hiding this comment.
It's just to match the default value that actually gets used from the config
utapi/libV2/config/defaults.json
Line 20 in 45e0ef1
4e2eebf to
9d4031a
Compare
|
/approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue UTAPI-122. Goodbye tmacro. The following options are set: approve |
This PR reverts the upgrade of @senx/warp10 to 2.0.3
Versions newer than 1.0.14 contain a bug that prevents setting a custom request timeout.