Skip to content

UTAPI-122: Fix warp10 client timeouts#1332

Merged
bert-e merged 4 commits intodevelopment/8.2from
bugfix/UTAPI-122/fix_warp10_client_timeouts
Apr 17, 2026
Merged

UTAPI-122: Fix warp10 client timeouts#1332
bert-e merged 4 commits intodevelopment/8.2from
bugfix/UTAPI-122/fix_warp10_client_timeouts

Conversation

@tmacro
Copy link
Copy Markdown
Contributor

@tmacro tmacro commented Apr 15, 2026

This PR reverts the upgrade of @senx/warp10 to 2.0.3
Versions newer than 1.0.14 contain a bug that prevents setting a custom request timeout.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 15, 2026

Hello tmacro,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 15, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Comment thread libV2/warp10.js
Comment on lines +20 to +22
this._requestTimeout = (config && config.requestTimeout) || 60000;
this._connectTimeout = (config && config.connectTimeout) || 60000;
this._client = new Warp10(`${proto}://${host}:${port}`, this._requestTimeout, this._connectTimeout);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some comments for the reasoning of choosing this value please for the future us.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just to match the default value that actually gets used from the config

"requestTimeout": 60000,

@tmacro tmacro force-pushed the bugfix/UTAPI-122/fix_warp10_client_timeouts branch from 4e2eebf to 9d4031a Compare April 16, 2026 23:52
@tmacro
Copy link
Copy Markdown
Contributor Author

tmacro commented Apr 17, 2026

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 17, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.2

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1

Please check the status of the associated issue UTAPI-122.

Goodbye tmacro.

The following options are set: approve

@bert-e bert-e merged commit 9d4031a into development/8.2 Apr 17, 2026
15 checks passed
@bert-e bert-e deleted the bugfix/UTAPI-122/fix_warp10_client_timeouts branch April 17, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants