S3UTILS-228: allow custom repd port in check-replication-permissions by nicolas2bert · Pull Request #382 · scality/s3utils

nicolas2bert · 2026-04-03T08:49:27Z

On 3-server rings, vault repd instances share hosts and bind to incremental ports (4300, 4301, …). The script had port 4300 hard-coded, so it silently connected to a follower when the leader was on another port, causing "Role not found in vault" for every bucket.

Parse argv[3] as ip[:port], default port to 4300 when omitted
Export parseLeaderAddress and add unit tests
Update README: CLI table, workflow examples, troubleshooting

On 3-server rings, vault repd instances share hosts and bind to incremental ports (4300, 4301, …). The script had port 4300 hard-coded, so it silently connected to a follower when the leader was on another port, causing "Role not found in vault" for every bucket. - Parse argv[3] as ip[:port], default port to 4300 when omitted - Export parseLeaderAddress and add unit tests - Update README: CLI table, workflow examples, troubleshooting

bert-e · 2026-04-03T08:49:32Z

Hello nicolas2bert,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2026-04-03T08:49:36Z

Incorrect fix version

The Fix Version/s in issue S3UTILS-228 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

1.17.6
1.18.0

Please check the Fix Version/s of S3UTILS-228, or the target
branch of this pull request.

claude · 2026-04-03T08:50:35Z

LGTM

Review by Claude Code

codecov · 2026-04-03T08:55:13Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.16%. Comparing base (fa6161a) to head (2169cb2).
⚠️ Report is 7 commits behind head on development/1.17.

Additional details and impacted files

@@                 Coverage Diff                  @@
##           development/1.17     #382      +/-   ##
====================================================
+ Coverage             44.12%   44.16%   +0.04%     
====================================================
  Files                    88       88              
  Lines                  6448     6453       +5     
  Branches               1348     1349       +1     
====================================================
+ Hits                   2845     2850       +5     
  Misses                 3555     3555              
  Partials                 48       48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bert-e · 2026-04-19T09:55:47Z

Incorrect fix version

The Fix Version/s in issue S3UTILS-228 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

1.17.8
1.18.0

Please check the Fix Version/s of S3UTILS-228, or the target
branch of this pull request.

scality-gdoumergue

LGTM

bert-e · 2026-04-23T07:43:55Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

nicolas2bert · 2026-04-23T07:53:10Z

/create_integration_branches

bert-e · 2026-04-23T07:53:19Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/S3UTILS-228/port into
development/1.17
w/1/bugfix/S3UTILS-228/port will be merged into development/1

The following branches will NOT be impacted:

development/1.13
development/1.14
development/1.15
development/1.16
development/1.4
development/1.7

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2026-04-23T07:53:20Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

nicolas2bert · 2026-04-23T08:57:54Z

@bert-e approve

bert-e · 2026-04-23T08:58:07Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/1.17
✔️ development/1

The following branches will NOT be impacted:

development/1.13
development/1.14
development/1.15
development/1.16
development/1.4
development/1.7

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_integration_branches

bert-e · 2026-04-23T08:58:31Z

Queue build failed

The corresponding build for the queue failed:

Checkout the status page.
Identify the failing build and review the logs.
If no issue is found, re-run the build.
If an issue is identified, checkout the steps below to remove
the pull request from the queue for further analysis and maybe rebase/merge.

Remove the pull request from the queue

Add a /wait comment on this pull request.
Click on login on the status page.
Go into the manage page.
Find the option called Rebuild the queue and click on it.
Bert-E will loop again on all pull requests to put the valid ones
in the queue again, while skipping the one with the /wait comment.
Wait for the new queue to merge, then merge/rebase your pull request
with the latest changes to then work on a proper fix.
Once the issue is fixed, delete the /wait comment and
follow the usual process to merge the pull request.

scality-gdoumergue approved these changes Apr 22, 2026

View reviewed changes

anurag4DSB approved these changes Apr 23, 2026

View reviewed changes

Conversation

nicolas2bert commented Apr 3, 2026

Uh oh!

bert-e commented Apr 3, 2026

Hello nicolas2bert,

Uh oh!

bert-e commented Apr 3, 2026

Incorrect fix version

Uh oh!

claude Bot commented Apr 3, 2026

Uh oh!

codecov Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bert-e commented Apr 19, 2026

Incorrect fix version

Uh oh!

scality-gdoumergue left a comment

Choose a reason for hiding this comment

Uh oh!

bert-e commented Apr 23, 2026

Request integration branches

Uh oh!

nicolas2bert commented Apr 23, 2026

Uh oh!

bert-e commented Apr 23, 2026

Integration data created

Uh oh!

bert-e commented Apr 23, 2026

Waiting for approval

Uh oh!

nicolas2bert commented Apr 23, 2026

Uh oh!

bert-e commented Apr 23, 2026

In the queue

Uh oh!

bert-e commented Apr 23, 2026

Queue build failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Apr 3, 2026 •

edited

Loading