Improvement/c UI 12 modal guideline enforcement#1089
Draft
JeanMarcMilletScality wants to merge 2 commits intodevelopment/1.0from
Draft
Improvement/c UI 12 modal guideline enforcement#1089JeanMarcMilletScality wants to merge 2 commits intodevelopment/1.0from
JeanMarcMilletScality wants to merge 2 commits intodevelopment/1.0from
Conversation
Contributor
Hello jeanmarcmilletscality,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
- Make footer required and introduce discriminated union Props to forbid close on alertdialog at the type level - Replace min-width: 250px with max-width: 90vw on ModalContent so the modal grows with its content but stays within the viewport - Add box-sizing: border-box + min-width: 450px on ModalBody; cap direct text/form children to 450px while allowing native tables and core-ui Table (role="grid") to push the modal wider - Add four valalint rules: modal-footer-required, modal-footer-stack-alignment, modal-title-string, modal-alertdialog-no-close Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
b9d1da6 to
bf690fc
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP