Skip to content

Improvement/c UI 12 modal guideline enforcement#1089

Draft
JeanMarcMilletScality wants to merge 2 commits intodevelopment/1.0from
improvement/CUI-12-modal-guideline-enforcement
Draft

Improvement/c UI 12 modal guideline enforcement#1089
JeanMarcMilletScality wants to merge 2 commits intodevelopment/1.0from
improvement/CUI-12-modal-guideline-enforcement

Conversation

@JeanMarcMilletScality
Copy link
Copy Markdown
Contributor

WIP

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 23, 2026

Hello jeanmarcmilletscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 23, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

- Make footer required and introduce discriminated union Props to forbid
  close on alertdialog at the type level
- Replace min-width: 250px with max-width: 90vw on ModalContent so the
  modal grows with its content but stays within the viewport
- Add box-sizing: border-box + min-width: 450px on ModalBody; cap direct
  text/form children to 450px while allowing native tables and core-ui
  Table (role="grid") to push the modal wider
- Add four valalint rules: modal-footer-required, modal-footer-stack-alignment,
  modal-title-string, modal-alertdialog-no-close

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@JeanMarcMilletScality JeanMarcMilletScality force-pushed the improvement/CUI-12-modal-guideline-enforcement branch from b9d1da6 to bf690fc Compare April 23, 2026 14:11
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants