refactor test organisation #2383
+3,655
−9,527
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| --- | ||
| name: Setup Node environment | ||
| description: > | ||
| Create a GitHub App token for private repo access, configure git, | ||
| set up Node.js with yarn cache, and install test dependencies. | ||
|
|
||
| inputs: | ||
| app-id: | ||
| description: GitHub App ID | ||
| required: true | ||
| private-key: | ||
| description: GitHub App private key | ||
| required: true | ||
| repositories: | ||
| description: Newline-separated list of private repositories to grant access to | ||
|
Contributor
There was a problem hiding this comment. before the refactor, each job explicitly requested only the repos it consumes:
Contributor
Author
There was a problem hiding this comment. Yeah I noticed this stuff, not sure it's super important, but yeah I removed the default value and re-add explicit repo list |
||
| required: true | ||
|
|
||
| outputs: | ||
| token: | ||
| description: The generated GitHub App token | ||
| value: ${{ steps.app-token.outputs.token }} | ||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: Get token to access private repositories | ||
| uses: actions/create-github-app-token@v3 | ||
| id: app-token | ||
| with: | ||
| app-id: ${{ inputs.app-id }} | ||
| private-key: ${{ inputs.private-key }} | ||
| owner: ${{ github.repository_owner }} | ||
| repositories: ${{ inputs.repositories }} | ||
| - name: Configure GIT | ||
| shell: bash | ||
| run: | | ||
| git config --global url."https://x-access-token:${GIT_ACCESS_TOKEN}@github.com/".insteadOf "https://github.com/" | ||
| git config --global --add url."https://x-access-token:${GIT_ACCESS_TOKEN}@github.com/".insteadOf "git@github.com:" | ||
| git config --global --add url."https://x-access-token:${GIT_ACCESS_TOKEN}@github.com/".insteadOf "ssh://git@github.com/" | ||
| env: | ||
| GIT_ACCESS_TOKEN: ${{ steps.app-token.outputs.token }} | ||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: '24' | ||
| cache: yarn | ||
| cache-dependency-path: tests/functional/yarn.lock | ||
| - name: Install test dependencies | ||
| shell: bash | ||
| working-directory: tests/functional | ||
| run: >- | ||
| yarn install --frozen-lockfile --network-concurrency 1 || ( | ||
| yarn cache clean && yarn install --frozen-lockfile --network-concurrency 1 | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end2end.yaml file was like 700 lines, with like ~6 nodes setup so I think this is better