added kmip server side encryption tests#2379
added kmip server side encryption tests#2379SylvainSenechal wants to merge 1 commit intodevelopment/2.14from
Conversation
Hello sylvainsenechal,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
f425fb3 to
b926a78
Compare
b926a78 to
c30eecf
Compare
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
| sourceRegistry: ghcr.io/scality | ||
| image: zenko-operator | ||
| tag: v1.8.9 | ||
| tag: 15b35ecc60bc8b83e855e0cb17091b10e592aa07 |
There was a problem hiding this comment.
TO BE DONE
!
| }); | ||
| }); | ||
|
|
||
| Before({ tags: '@ServerSideEncryptionKmip', timeout: 15 * 60 * 1000 }, |
There was a problem hiding this comment.
best i can come up with in CUCUMBER TESTS to have certains tests ran after others
There was a problem hiding this comment.
again, might have added too many tests that aren't super useful for FUNCTIONAL testing 🤔
| }); | ||
| }); | ||
|
|
||
| Before({ tags: '@ServerSideEncryptionKmip', timeout: 15 * 60 * 1000 }, |
There was a problem hiding this comment.
Do we need an After/cleanup for this? Like I guess we make changes to the Zenko CR while the tests are running because we don't want to affect other tests; but then we should clear our changes before the next tests run, no?
Issue: ZENKO-5241
Adding more encryption tests but with KMIP mode
A bit annoying as we need to patch the CR, and when kmip mode is enabled, the base encryption tests don't work anymore