Expose Additional Config Options#238
Open
wazoo wants to merge 6 commits intosbadia:masterfrom
wazoo:additional-options
Open
Expose Additional Config Options#238wazoo wants to merge 6 commits intosbadia:masterfrom wazoo:additional-options
wazoo wants to merge 6 commits intosbadia:masterfrom
wazoo:additional-options
Conversation
Author
|
Whoops I forgot to add the options to init.pp, ignore this until that is done. |
Author
|
Okay, all documented, initialized and validated, should be good to go! I have no idea why those builds are failing, when running it locally I get: Puppet::PreformattedError: That is absolutely a function, it is part of puppetlabs/stdlib (in the version in this packages metadata): validate_integer It looks like it was added not that long ago so maybe there is a testing gem out of date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking for the option to change the default theme and I discovered there were quite a few options that weren't exposed so I went and found as many as I could and exposed them with additional options.
As with my other pull requests, the same tests fail when I do a
rake specon master vs this branch so I am not sure whats up with that. I didn't see tests for every single option (seemed there were a few but not total coverage) so I didn't add any for the ones I added, I can do that if need be.