Repository navigation
Conversation
…gation_plugin_connection # Conflicts: # app/src/main/java/com/sameerasw/essentials/data/repository/SettingsRepository.kt # app/src/main/java/com/sameerasw/essentials/domain/registry/FeatureRegistry.kt # app/src/main/java/com/sameerasw/essentials/island/service/IslandCoordinator.kt # app/src/main/java/com/sameerasw/essentials/ui/features/display/IslandSettingsUI.kt # app/src/main/java/com/sameerasw/essentials/viewmodels/MainViewModel.kt # app/src/main/res/values/strings.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable navigation popup on island when any type of navigation.
Navigation only accepts ongoing notifications that pass isNavigationNotification. That means the channel ID is in the navigation channel list or contains "navigation", or the category contains "navigation".
Maps' Live Update has a progress bar, so it would also qualify for the progress ring. While the island and its Navigation item are on, extractLatestProgressNotification skips navigation notifications, so the progress plugin doesn't show it a second time.
Inside the changes a couple of settings can be enabled inside the toggle:
This implementation was only tested on a real device and on an emulator with no issues, Waze doesn't create any notification with nav info apart of the only persistent notification to keep the app alive.
Type of change
UI changes
Screen-20261012-181522-1791853972543.Mp4.2.mp4
Screen_recording_20261013_115734.webm
Checklist
Before submitting, please make sure:
develop(notmain)../gradlew assembleDebug../gradlew testDebugUnitTest.SettingsRepositoryfor keys and getter/setter methods.FeatureRegistry.ktfor search indexing.ui/core/(RoundedCardContainer,IconToggleItem, etc.).res/values/strings.xmland drawables use rounded variants (R.drawable.rounded_*).